Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: third_party/WebKit/Source/platform/audio/Panner.cpp

Issue 2272683003: Remove redundant definition of Spatializer abstract class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Detach StereoPanner from Panner base class (plus rebasing) Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 26 matching lines...) Expand all
37 std::unique_ptr<Panner> Panner::create(PanningModel model, float sampleRate, HRT FDatabaseLoader* databaseLoader) 37 std::unique_ptr<Panner> Panner::create(PanningModel model, float sampleRate, HRT FDatabaseLoader* databaseLoader)
38 { 38 {
39 switch (model) { 39 switch (model) {
40 case PanningModelEqualPower: 40 case PanningModelEqualPower:
41 return wrapUnique(new EqualPowerPanner(sampleRate)); 41 return wrapUnique(new EqualPowerPanner(sampleRate));
42 42
43 case PanningModelHRTF: 43 case PanningModelHRTF:
44 return wrapUnique(new HRTFPanner(sampleRate, databaseLoader)); 44 return wrapUnique(new HRTFPanner(sampleRate, databaseLoader));
45 45
46 default: 46 default:
47 ASSERT_NOT_REACHED(); 47 NOTREACHED();
Raymond Toy 2016/08/24 18:30:29 Does the presubmit complain about this? If not, pl
hongchan 2016/08/24 21:52:33 Oh, actually NOTREACHED is the DCHECK versions of
48 return nullptr; 48 return nullptr;
49 } 49 }
50 } 50 }
51 51
52 } // namespace blink 52 } // namespace blink
53
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698