Consider pseudo classes as matching for shared style rejection.

Consider pseudo classes as matching for shared style rejection.

The user action pseudo classes rely on affectedBy bits to be correctly
set on ComputedStyle in order to recalculate style for such changes
later on. If two elements may otherwise share style, but will have the
affectedBy bits set differently, they may not share style.

Example:

  <style>[attr]:hover {}</style>
  <div></div>
  <div attr></div>

The second div may share style with the first one when none of them is
hovered. However, matching the selector against the first div will fail
on the attribute selector before we try to match :hover, hence the flag
for affectedByHover will not be set. If we share that ComputedStyle
object with the second div, hovering the second div later will have no
effect.

Instead we always match :hover/:active/:focus/:-webkit-drag when
matching rules for style sharing (attribute and sibling rules). That
will lead to the attribute selector in the example above to match which
will cause style sharing to be rejected for the second div.

R=meade@chromium.org
BUG=639561
Committed: https://crrev.com/b2aee8879058a6a85104073c38868e4edd66b628
Cr-Commit-Position: refs/heads/master@{#414221}

[rune, 2016-08-23 14:56:20]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 14:56:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rune, 2016-08-23 14:56:52]

ptal

[commit-bot: I haz the power, 2016-08-23 15:35:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 15:35:01]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[rune, 2016-08-23 17:18:02]

On 2016/08/23 14:56:52, rune wrote:
> ptal

I'm afraid this won't work correctly for negated pseudos. I need to revisit.

[rune, 2016-08-24 11:23:02]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 11:23:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rune, 2016-08-24 11:23:41]

On 2016/08/23 17:18:02, rune wrote:
> On 2016/08/23 14:56:52, rune wrote:
> > ptal
> 
> I'm afraid this won't work correctly for negated pseudos. I need to revisit.

Ready for review.

[commit-bot: I haz the power, 2016-08-24 13:11:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 13:11:21]

Dry run: This issue passed the CQ dry run.

[meade_UTC10, 2016-08-25 00:24:57]

lgtm

[rune, 2016-08-25 00:25:52]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-08-25 00:27:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 00:34:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-25 00:35:54]

Description was changed from

==========
Consider pseudo classes as matching for shared style rejection.

The user action pseudo classes rely on affectedBy bits to be correctly
set on ComputedStyle in order to recalculate style for such changes
later on. If two elements may otherwise share style, but will have the
affectedBy bits set differently, they may not share style.

Example:

  <style>[attr]:hover {}</style>
  <div></div>
  <div attr></div>

The second div may share style with the first one when none of them is
hovered. However, matching the selector against the first div will fail
on the attribute selector before we try to match :hover, hence the flag
for affectedByHover will not be set. If we share that ComputedStyle
object with the second div, hovering the second div later will have no
effect.

Instead we always match :hover/:active/:focus/:-webkit-drag when
matching rules for style sharing (attribute and sibling rules). That
will lead to the attribute selector in the example above to match which
will cause style sharing to be rejected for the second div.

R=meade@chromium.org
BUG=639561
==========

to

==========
Consider pseudo classes as matching for shared style rejection.

The user action pseudo classes rely on affectedBy bits to be correctly
set on ComputedStyle in order to recalculate style for such changes
later on. If two elements may otherwise share style, but will have the
affectedBy bits set differently, they may not share style.

Example:

  <style>[attr]:hover {}</style>
  <div></div>
  <div attr></div>

The second div may share style with the first one when none of them is
hovered. However, matching the selector against the first div will fail
on the attribute selector before we try to match :hover, hence the flag
for affectedByHover will not be set. If we share that ComputedStyle
object with the second div, hovering the second div later will have no
effect.

Instead we always match :hover/:active/:focus/:-webkit-drag when
matching rules for style sharing (attribute and sibling rules). That
will lead to the attribute selector in the example above to match which
will cause style sharing to be rejected for the second div.

R=meade@chromium.org
BUG=639561

Committed: https://crrev.com/b2aee8879058a6a85104073c38868e4edd66b628
Cr-Commit-Position: refs/heads/master@{#414221}
==========

[commit-bot: I haz the power, 2016-08-25 00:35:55]

Patchset 3 (id:??) landed as
https://crrev.com/b2aee8879058a6a85104073c38868e4edd66b628
Cr-Commit-Position: refs/heads/master@{#414221}