Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2272673003: Remove anchor view from container when reset (Closed)

Created:
4 years, 4 months ago by Jinsuk Kim
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove anchor view from container when reset Makes sure ScopedAnchorView::Reset() removes the anchor view from its container view through JNI. This prevents potential leaks when the destructor fails to do the cleaning job. Not apparently related to the bug, but it helps avoid any issues that may happen in the future. Also deleted a method declaration of |SetWindowAndroid| sneaked in by mistake. BUG=635515 Committed: https://crrev.com/0a717f521200898d1fe45c37b351daad1c4a4a32 Cr-Commit-Position: refs/heads/master@{#414154}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M ui/android/view_android.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/android/view_android.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Jinsuk Kim
Note: The change will have the destructor call delegate_.reset() in addition to what was being ...
4 years, 4 months ago (2016-08-24 01:25:18 UTC) #2
David Trainor- moved to gerrit
lgtm
4 years, 4 months ago (2016-08-24 03:18:22 UTC) #3
no sievers
lgtm, thanks!
4 years, 4 months ago (2016-08-24 18:48:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272673003/1
4 years, 4 months ago (2016-08-24 18:49:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 21:42:26 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 21:44:24 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a717f521200898d1fe45c37b351daad1c4a4a32
Cr-Commit-Position: refs/heads/master@{#414154}

Powered by Google App Engine
This is Rietveld 408576698