Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Issue 2272653003: Fix GN bootstrap (Closed)

Created:
4 years, 4 months ago by Paweł Hajdan Jr.
Modified:
4 years, 3 months ago
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M tools/gn/bootstrap/bootstrap.py View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Paweł Hajdan Jr.
4 years, 4 months ago (2016-08-24 08:23:29 UTC) #2
brettw
lgtm
4 years, 4 months ago (2016-08-24 19:24:37 UTC) #3
jochen (gone - plz use gerrit)
can we somehow automate keeping this list in sync?
4 years, 4 months ago (2016-08-24 20:46:35 UTC) #4
Paweł Hajdan Jr.
On 2016/08/24 at 20:46:35, jochen wrote: > can we somehow automate keeping this list in ...
4 years, 3 months ago (2016-08-25 09:45:48 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/45b76eee26221b1464f3c958bb49a568a6fd642d Cr-Commit-Position: refs/heads/master@{#414376}
4 years, 3 months ago (2016-08-25 09:51:57 UTC) #8
Paweł Hajdan Jr.
4 years, 3 months ago (2016-08-25 09:53:35 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
45b76eee26221b1464f3c958bb49a568a6fd642d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698