[turbofan] Fix constructor inlining control wiring.

[turbofan] Fix constructor inlining control wiring.

This makes sure the check of the return value of an inlined constructor
call is properly wired into the control chain. The check only happens on
successful completion of the underlying call and hence is wired into the
success latch of the control projections.

R=jarin@chromium.org

Committed: https://crrev.com/86d409789a9d7d1e1f1b616ee459f73bd0651d8a
Cr-Commit-Position: refs/heads/master@{#38820}

[Michael Starzinger, 2016-08-23 12:08:44]

The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 12:08:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Starzinger, 2016-08-23 12:11:12]

mstarzinger@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[Michael Starzinger, 2016-08-23 12:11:13]

Jaro: PTAL.
Ross: FYI.

[Jarin, 2016-08-23 12:30:03]

lgtm.

https://codereview.chromium.org/2272633002/diff/1/src/compiler/js-inlining.cc
File src/compiler/js-inlining.cc (right):

https://codereview.chromium.org/2272633002/diff/1/src/compiler/js-inlining.cc...
src/compiler/js-inlining.cc:450: NodeProperties::ReplaceControlInput(success,
node);
Please add a comment explaining that these are fixups.

[commit-bot: I haz the power, 2016-08-23 12:33:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 12:33:50]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2016-08-23 12:37:34]

The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 12:37:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Starzinger, 2016-08-23 12:39:04]

Thanks! Addressed comments. Landing.

https://codereview.chromium.org/2272633002/diff/1/src/compiler/js-inlining.cc
File src/compiler/js-inlining.cc (right):

https://codereview.chromium.org/2272633002/diff/1/src/compiler/js-inlining.cc...
src/compiler/js-inlining.cc:450: NodeProperties::ReplaceControlInput(success,
node);
On 2016/08/23 12:30:03, Jarin wrote:
> Please add a comment explaining that these are fixups.

Done.

[Michael Starzinger, 2016-08-23 12:39:40]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2016-08-23 12:39:40]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2272633002/#ps40001
(title: "Better comments.")

[commit-bot: I haz the power, 2016-08-23 12:39:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rmcilroy, 2016-08-23 12:56:46]

LGTM.

[commit-bot: I haz the power, 2016-08-23 13:03:32]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-23 13:03:50]

Description was changed from

==========
[turbofan] Fix constructor inlining control wiring.

This makes sure the check of the return value of an inlined constructor
call is properly wired into the control chain. The check only happens on
successful completion of the underlying call and hence is wired into the
success latch of the control projections.

R=jarin@chromium.org
==========

to

==========
[turbofan] Fix constructor inlining control wiring.

This makes sure the check of the return value of an inlined constructor
call is properly wired into the control chain. The check only happens on
successful completion of the underlying call and hence is wired into the
success latch of the control projections.

R=jarin@chromium.org

Committed: https://crrev.com/86d409789a9d7d1e1f1b616ee459f73bd0651d8a
Cr-Commit-Position: refs/heads/master@{#38820}
==========

[commit-bot: I haz the power, 2016-08-23 13:03:52]

Patchset 3 (id:??) landed as
https://crrev.com/86d409789a9d7d1e1f1b616ee459f73bd0651d8a
Cr-Commit-Position: refs/heads/master@{#38820}