third_party/WebKit/Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp - Issue 2272613003: binding: Retires ExceptionState::throwIfNeeded().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp

Issue 2272613003: binding: Retires ExceptionState::throwIfNeeded(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp ('k') | third_party/WebKit/Source/bindings/modules/v8/V8ServiceWorkerMessageEventInternal.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp

index 3ba760ed3dcf5109102cf5c1d42e37a3d0f89bea..c881f69c1c14878a093c8e33ca71d954b0ea3a29 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp

@@ -54,8 +54,6 @@ void V8XMLHttpRequest::responseTextAttributeGetterCustom(const v8::FunctionCallb

XMLHttpRequest* xmlHttpRequest = V8XMLHttpRequest::toImpl(info.Holder());

ExceptionState exceptionState(ExceptionState::GetterContext, "responseText", "XMLHttpRequest", info.Holder(), info.GetIsolate());

ScriptString text = xmlHttpRequest->responseText(exceptionState);

- if (exceptionState.throwIfNeeded())

- return;

if (text.isEmpty()) {

v8SetReturnValueString(info, emptyString(), info.GetIsolate());

return;

@@ -98,8 +96,6 @@ void V8XMLHttpRequest::responseAttributeGetterCustom(const v8::FunctionCallbackI

{

ExceptionState exceptionState(ExceptionState::GetterContext, "response", "XMLHttpRequest", info.Holder(), info.GetIsolate());

Document* document = xmlHttpRequest->responseXML(exceptionState);

- if (exceptionState.throwIfNeeded())

- return;

v8SetReturnValueFast(info, document, xmlHttpRequest);

return;

}