third_party/WebKit/Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp - Issue 2272613003: binding: Retires ExceptionState::throwIfNeeded().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp

Issue 2272613003: binding: Retires ExceptionState::throwIfNeeded(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp

index 49a8b3a0525a17b44e08c4c02fe52e56bc6c3076..827478fad40e6cccfce422e2762741a2d183cc15 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp

@@ -46,14 +46,12 @@ void V8MutationObserver::constructorCustom(const v8::FunctionCallbackInfo<v8::Va

ExceptionState exceptionState(ExceptionState::ConstructionContext, "MutationObserver", info.Holder(), info.GetIsolate());

if (info.Length() < 1) {

exceptionState.throwTypeError(ExceptionMessages::notEnoughArguments(1, info.Length()));

- exceptionState.throwIfNeeded();

return;

}

v8::Local<v8::Value> arg = info[0];

if (!arg->IsFunction()) {

exceptionState.throwTypeError("Callback argument must be a function");

- exceptionState.throwIfNeeded();

return;

}