third_party/WebKit/Source/bindings/core/v8/custom/V8IntersectionObserverCustom.cpp - Issue 2272613003: binding: Retires ExceptionState::throwIfNeeded().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8IntersectionObserverCustom.cpp

Issue 2272613003: binding: Retires ExceptionState::throwIfNeeded(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8IntersectionObserverCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8IntersectionObserverCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8IntersectionObserverCustom.cpp

index 38cd3bb4b276afae825b8b274caa8b477d88c2a9..ae06a2a2729f08e8a0344f99db1a0ef0481c79c0 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8IntersectionObserverCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8IntersectionObserverCustom.cpp

@@ -36,12 +36,12 @@ void V8IntersectionObserver::constructorCustom(const v8::FunctionCallbackInfo<v8

IntersectionObserverInit intersectionObserverInit;

ExceptionState exceptionState(ExceptionState::ConstructionContext, "Intersection", info.Holder(), info.GetIsolate());

V8IntersectionObserverInit::toImpl(info.GetIsolate(), info[1], intersectionObserverInit, exceptionState);

- if (exceptionState.throwIfNeeded())

+ if (exceptionState.hadException())

return;

IntersectionObserverCallback* callback = new V8IntersectionObserverCallback(v8::Local<v8::Function>::Cast(info[0]), wrapper, ScriptState::current(info.GetIsolate()));

IntersectionObserver* observer = IntersectionObserver::create(intersectionObserverInit, *callback, exceptionState);

- if (exceptionState.throwIfNeeded())

+ if (exceptionState.hadException())

return;

ASSERT(observer);

v8SetReturnValue(info, V8DOMWrapper::associateObjectWithWrapper(info.GetIsolate(), observer, &wrapperTypeInfo, wrapper));