binding: Retires ExceptionState::throwIfNeeded().

third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp
index ec2cd820508f6237ea85c888a8ed6b760d5aa9a4..9fd507af5c2fafc65b68678987a2f76c97a1bc5e 100644
--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp
@@ -87,8 +87,6 @@ void V8Document::openMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& inf
 
     ExceptionState exceptionState(ExceptionState::ExecutionContext, "open", "Document", info.Holder(), info.GetIsolate());
     document->open(enteredDOMWindow(info.GetIsolate())->document(), exceptionState);
-    if (exceptionState.throwIfNeeded())

[haraken, 2016/08/24 13:33:02]

Don't you need to change this to:

  if (exceptionState.hadException())
    return;

?

Otherwise info.Holder() will be set to the return value when an exception is
thrown.

The same comment for other files in this CL.

[Yuki, 2016/08/24 13:36:20]

Exactly speaking, info.GetReturnValue() will be set to the return value,
however, since an exception will be thrown, user script never observes the
return value.  So practically it's okay.

In general, when an exception is thrown, a return value is just ignored.

-        return;
 
     v8SetReturnValue(info, info.Holder());
 }