third_party/WebKit/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp - Issue 2272613003: binding: Retires ExceptionState::throwIfNeeded().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp

Issue 2272613003: binding: Retires ExceptionState::throwIfNeeded(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Synced. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp

index 873539f50be2a7bad239f479c4ee94279d1594c6..16088db2bb8c285f5fb38558c6747c42e45e0833 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp

@@ -120,10 +120,10 @@ void V8DevToolsHost::showContextMenuAtPointMethodCustom(const v8::FunctionCallba

v8::Isolate* isolate = info.GetIsolate();

float x = toRestrictedFloat(isolate, info[0], exceptionState);

- if (exceptionState.throwIfNeeded())

+ if (exceptionState.hadException())

return;

float y = toRestrictedFloat(isolate, info[1], exceptionState);

- if (exceptionState.throwIfNeeded())

+ if (exceptionState.hadException())

return;

v8::Local<v8::Value> array = v8::Local<v8::Value>::Cast(info[2]);

@@ -155,4 +155,3 @@ void V8DevToolsHost::showContextMenuAtPointMethodCustom(const v8::FunctionCallba

}

} // namespace blink