Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Side by Side Diff: content/common/ssl_status_serialization_unittest.cc

Issue 2272603003: Route key_exchange_group over to DevTools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix test maybe Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/common/ssl_status_serialization.h" 5 #include "content/common/ssl_status_serialization.h"
6 6
7 #include "net/ssl/ssl_connection_status_flags.h" 7 #include "net/ssl/ssl_connection_status_flags.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 9
10 namespace content { 10 namespace content {
11 11
12 namespace { 12 namespace {
13 13
14 void SetTestStatus(SSLStatus* status) { 14 void SetTestStatus(SSLStatus* status) {
15 status->security_style = SECURITY_STYLE_AUTHENTICATED; 15 status->security_style = SECURITY_STYLE_AUTHENTICATED;
16 status->cert_id = 1; 16 status->cert_id = 1;
17 status->cert_status = net::CERT_STATUS_DATE_INVALID; 17 status->cert_status = net::CERT_STATUS_DATE_INVALID;
18 status->security_bits = 80; 18 status->security_bits = 80;
19 status->key_exchange_info = 23; 19 status->key_exchange_group = 23;
20 status->connection_status = net::SSL_CONNECTION_VERSION_TLS1_2; 20 status->connection_status = net::SSL_CONNECTION_VERSION_TLS1_2;
21 status->sct_statuses.push_back(net::ct::SCT_STATUS_OK); 21 status->sct_statuses.push_back(net::ct::SCT_STATUS_OK);
22 } 22 }
23 23
24 bool SSLStatusAreEqual(const SSLStatus& a, const SSLStatus &b) { 24 bool SSLStatusAreEqual(const SSLStatus& a, const SSLStatus &b) {
25 return a.Equals(b); 25 return a.Equals(b);
26 } 26 }
27 27
28 } // namespace 28 } // namespace
29 29
30 std::ostream& operator<<(std::ostream& os, const SSLStatus& status) { 30 std::ostream& operator<<(std::ostream& os, const SSLStatus& status) {
31 return os << "Security Style: " << status.security_style 31 return os << "Security style: " << status.security_style
32 << "\nCert ID: " << status.cert_id 32 << "\nCert ID: " << status.cert_id
33 << "\nCert Status: " << status.cert_status 33 << "\nCert status: " << status.cert_status
34 << "\nSecurity bits: " << status.security_bits 34 << "\nSecurity bits: " << status.security_bits
35 << "\nKey exchange info: " << status.key_exchange_info 35 << "\nKey exchange group: " << status.key_exchange_group
36 << "\nConnection status: " << status.connection_status 36 << "\nConnection status: " << status.connection_status
37 << "\nContent Status: " << status.content_status 37 << "\nContent status: " << status.content_status
38 << "\nNumber of SCTs: " << status.sct_statuses.size(); 38 << "\nNumber of SCTs: " << status.sct_statuses.size();
39 } 39 }
40 40
41 // Test that a valid serialized SSLStatus returns true on 41 // Test that a valid serialized SSLStatus returns true on
42 // deserialization and deserializes correctly. 42 // deserialization and deserializes correctly.
43 TEST(SSLStatusSerializationTest, DeserializeSerializedStatus) { 43 TEST(SSLStatusSerializationTest, DeserializeSerializedStatus) {
44 // Serialize dummy data and test that it deserializes properly. 44 // Serialize dummy data and test that it deserializes properly.
45 SSLStatus status; 45 SSLStatus status;
46 SetTestStatus(&status); 46 SetTestStatus(&status);
47 std::string serialized = SerializeSecurityInfo(status); 47 std::string serialized = SerializeSecurityInfo(status);
(...skipping 24 matching lines...) Expand all
72 // |security_bits| must be <-1. (-1 means the strength is unknown, and 72 // |security_bits| must be <-1. (-1 means the strength is unknown, and
73 // |0 means the connection is not encrypted). 73 // |0 means the connection is not encrypted).
74 status.security_bits = -5; 74 status.security_bits = -5;
75 std::string serialized = SerializeSecurityInfo(status); 75 std::string serialized = SerializeSecurityInfo(status);
76 76
77 SSLStatus invalid_deserialized; 77 SSLStatus invalid_deserialized;
78 ASSERT_FALSE(DeserializeSecurityInfo(serialized, &invalid_deserialized)); 78 ASSERT_FALSE(DeserializeSecurityInfo(serialized, &invalid_deserialized));
79 EXPECT_PRED2(SSLStatusAreEqual, SSLStatus(), invalid_deserialized); 79 EXPECT_PRED2(SSLStatusAreEqual, SSLStatus(), invalid_deserialized);
80 } 80 }
81 81
82 // Serialize a status with a bad |key_exchange_info| value and test that
83 // deserializing it fails.
84 TEST(SSLStatusSerializationTest, DeserializeBogusKeyExchangeInfo) {
85 SSLStatus status;
86 SetTestStatus(&status);
87 status.key_exchange_info = -1;
88
89 SSLStatus invalid_deserialized;
90 std::string serialized = SerializeSecurityInfo(status);
91 ASSERT_FALSE(DeserializeSecurityInfo(serialized, &invalid_deserialized));
92 EXPECT_PRED2(SSLStatusAreEqual, SSLStatus(), invalid_deserialized);
93 }
94
95 // Serialize a status with a bad |security_style| value and test that 82 // Serialize a status with a bad |security_style| value and test that
96 // deserializing it fails. 83 // deserializing it fails.
97 TEST(SSLStatusSerializationTest, DeserializeBogusSecurityStyle) { 84 TEST(SSLStatusSerializationTest, DeserializeBogusSecurityStyle) {
98 SSLStatus status; 85 SSLStatus status;
99 SetTestStatus(&status); 86 SetTestStatus(&status);
100 status.security_style = static_cast<SecurityStyle>(100); 87 status.security_style = static_cast<SecurityStyle>(100);
101 std::string serialized = SerializeSecurityInfo(status); 88 std::string serialized = SerializeSecurityInfo(status);
102 89
103 SSLStatus invalid_deserialized; 90 SSLStatus invalid_deserialized;
104 ASSERT_FALSE(DeserializeSecurityInfo(serialized, &invalid_deserialized)); 91 ASSERT_FALSE(DeserializeSecurityInfo(serialized, &invalid_deserialized));
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 status.sct_statuses.push_back( 144 status.sct_statuses.push_back(
158 static_cast<net::ct::SCTVerifyStatus>(net::ct::SCT_STATUS_INVALID)); 145 static_cast<net::ct::SCTVerifyStatus>(net::ct::SCT_STATUS_INVALID));
159 std::string serialized = SerializeSecurityInfo(status); 146 std::string serialized = SerializeSecurityInfo(status);
160 147
161 SSLStatus deserialized; 148 SSLStatus deserialized;
162 ASSERT_TRUE(DeserializeSecurityInfo(serialized, &deserialized)); 149 ASSERT_TRUE(DeserializeSecurityInfo(serialized, &deserialized));
163 EXPECT_PRED2(SSLStatusAreEqual, status, deserialized); 150 EXPECT_PRED2(SSLStatusAreEqual, status, deserialized);
164 } 151 }
165 152
166 } // namespace 153 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698