Route key_exchange_group over to DevTools.

content/common/ssl_status_serialization.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/ssl_status_serialization.h"
 
 #include <stdint.h>
 
 #include "base/logging.h"
 #include "base/numerics/safe_conversions.h"
@@ skipping 32 matching lines @@
       // receive a status of NONE in a serialized SSLStatus.
       return false;
   }
   return false;
 }
 
 }  // namespace
 
 namespace content {
 
 std::string SerializeSecurityInfo(const SSLStatus& ssl_status) {

[nasko, 2016/09/01 17:15:22]

The result of this is never persisted on disk, right?

[davidben, 2016/09/02 21:48:05]

I don't think so, no. (We've done other incompatible changes before.) It's an
IPC thing.

   base::Pickle pickle;
   pickle.WriteInt(ssl_status.security_style);
   pickle.WriteInt(ssl_status.cert_id);
   pickle.WriteUInt32(ssl_status.cert_status);
   pickle.WriteInt(ssl_status.security_bits);
-  pickle.WriteInt(ssl_status.key_exchange_info);
+  pickle.WriteUInt16(ssl_status.key_exchange_group);
   pickle.WriteInt(ssl_status.connection_status);
   pickle.WriteUInt32(ssl_status.sct_statuses.size());
   for (const auto& sct_status : ssl_status.sct_statuses) {
     pickle.WriteUInt32(sct_status);
   }
   pickle.WriteBool(ssl_status.pkp_bypassed);
   return std::string(static_cast<const char*>(pickle.data()), pickle.size());
 }
 
 bool DeserializeSecurityInfo(const std::string& state, SSLStatus* ssl_status) {
   *ssl_status = SSLStatus();
 
   if (state.empty()) {
     // No SSL used.
     return true;
   }
 
   base::Pickle pickle(state.data(), base::checked_cast<int>(state.size()));
   base::PickleIterator iter(pickle);
   int security_style;
   if (!iter.ReadInt(&security_style) || !iter.ReadInt(&ssl_status->cert_id) ||
       !iter.ReadUInt32(&ssl_status->cert_status) ||
       !iter.ReadInt(&ssl_status->security_bits) ||
-      !iter.ReadInt(&ssl_status->key_exchange_info) ||
+      !iter.ReadUInt16(&ssl_status->key_exchange_group) ||
       !iter.ReadInt(&ssl_status->connection_status)) {
     *ssl_status = SSLStatus();
     return false;
   }
 
   uint32_t num_sct_statuses;
   if (!iter.ReadUInt32(&num_sct_statuses)) {
     return false;
   }
 
@@ skipping 18 matching lines @@
   }
 
   ssl_status->security_style = static_cast<SecurityStyle>(security_style);
 
   // Sanity check |security_bits|: the only allowed negative value is -1.
   if (ssl_status->security_bits < -1) {
     *ssl_status = SSLStatus();
     return false;
   }
 
-  // Sanity check |key_exchange_info|: 0 or greater.
-  if (ssl_status->key_exchange_info < 0) {
-    *ssl_status = SSLStatus();
-    return false;
-  }
-
   return true;
 }
 
 }  // namespace content