[Extensions] Convert some SyncExtensionFunctions

[Extensions] Convert some SyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove SyncExtensionFunctions from:
- tab_capture
- virtual_keyboard_private

BUG=634140
Committed: https://crrev.com/747c4ef945c423752e5e4b8de39b62c5caa69390
Cr-Commit-Position: refs/heads/master@{#414832}

[Devlin, 2016-08-25 22:08:59]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 22:09:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 22:21:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 22:21:15]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2016-08-25 22:43:52]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 22:44:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 22:58:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 22:58:41]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2016-08-26 00:44:10]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 00:44:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2016-08-26 01:48:21]

Patchset #1 (id:1) has been deleted

[Devlin, 2016-08-26 01:48:34]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-08-26 02:27:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 02:27:41]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-08-26 05:12:09]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org

[lazyboy, 2016-08-26 18:05:14]

https://codereview.chromium.org/2272563011/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/tab_capture/tab_capture_api.h (right):

https://codereview.chromium.org/2272563011/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/tab_capture/tab_capture_api.h:25: class
TabCaptureCaptureFunction : public ChromeSyncExtensionFunction {
This and GetCapturedTabsFunction still left out?
If intentionally then you need to update the CL desc.

[Devlin, 2016-08-26 18:23:35]

https://codereview.chromium.org/2272563011/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/tab_capture/tab_capture_api.h (right):

https://codereview.chromium.org/2272563011/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/tab_capture/tab_capture_api.h:25: class
TabCaptureCaptureFunction : public ChromeSyncExtensionFunction {
On 2016/08/26 18:05:14, lazyboy wrote:
> This and GetCapturedTabsFunction still left out?
> If intentionally then you need to update the CL desc.

Only addressing SyncExtensionFunction right now; will get to
ChromeSyncExtensionFunction in good time. :)  The CL description mentions that
this is SyncExtensionFunction - do you think it's necessary to say "but not
ChromeSyncExtensionFunction"?

[lazyboy, 2016-08-26 19:52:40]

lgtm

https://codereview.chromium.org/2272563011/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/tab_capture/tab_capture_api.h (right):

https://codereview.chromium.org/2272563011/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/tab_capture/tab_capture_api.h:25: class
TabCaptureCaptureFunction : public ChromeSyncExtensionFunction {
On 2016/08/26 18:23:35, Devlin wrote:
> On 2016/08/26 18:05:14, lazyboy wrote:
> > This and GetCapturedTabsFunction still left out?
> > If intentionally then you need to update the CL desc.
> 
> Only addressing SyncExtensionFunction right now; will get to
> ChromeSyncExtensionFunction in good time. :)  The CL description mentions that
> this is SyncExtensionFunction - do you think it's necessary to say "but not
> ChromeSyncExtensionFunction"?

My bad, I was looking at the second line of CL description thinking you were
removing all of them.
lgtm.

[Devlin, 2016-08-26 22:17:03]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-08-26 22:17:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 22:23:15]

Committed patchset #1 (id:40001)

[commit-bot: I haz the power, 2016-08-26 22:25:37]

Description was changed from

==========
[Extensions] Convert some SyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove SyncExtensionFunctions from:
- tab_capture
- virtual_keyboard_private

BUG=634140
==========

to

==========
[Extensions] Convert some SyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove SyncExtensionFunctions from:
- tab_capture
- virtual_keyboard_private

BUG=634140

Committed: https://crrev.com/747c4ef945c423752e5e4b8de39b62c5caa69390
Cr-Commit-Position: refs/heads/master@{#414832}
==========

[commit-bot: I haz the power, 2016-08-26 22:25:38]

Patchset 1 (id:??) landed as
https://crrev.com/747c4ef945c423752e5e4b8de39b62c5caa69390
Cr-Commit-Position: refs/heads/master@{#414832}