Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2272563003: Add an UMA histogram for WebUSB function calls. (Closed)

Created:
4 years, 4 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 4 months ago
Reviewers:
haraken, Steven Holte
CC:
asvitkine+watch_chromium.org, blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an UMA histogram for WebUSB function calls. Each WebUSB function (on the USB and USBDevice IDL objects) is given a histogram value that is recorded when the function is called. BUG=492204 Committed: https://crrev.com/9882e9ddab06dd2acc556707d0feb8c129a8b3c3 Cr-Commit-Position: refs/heads/master@{#414367}

Patch Set 1 #

Patch Set 2 : Make histogram names consistent. #

Total comments: 1

Patch Set 3 : Switch to UseCounter.h. #

Patch Set 4 : Rebased. #

Patch Set 5 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -3 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 3 4 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USB.cpp View 1 2 4 chunks +10 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBDevice.cpp View 1 2 16 chunks +31 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 37 (22 generated)
Reilly Grant (use Gerrit)
Please take a look, this is the first time I've added a histogram in Blink ...
4 years, 4 months ago (2016-08-23 20:00:34 UTC) #4
haraken
https://codereview.chromium.org/2272563003/diff/20001/third_party/WebKit/Source/modules/webusb/USBMetrics.h File third_party/WebKit/Source/modules/webusb/USBMetrics.h (right): https://codereview.chromium.org/2272563003/diff/20001/third_party/WebKit/Source/modules/webusb/USBMetrics.h#newcode29 third_party/WebKit/Source/modules/webusb/USBMetrics.h:29: UsbDeviceReset = 15, I'd prefer centralizing all UMA metrics ...
4 years, 4 months ago (2016-08-24 01:13:19 UTC) #8
Steven Holte
histograms lgtm
4 years, 4 months ago (2016-08-24 01:54:09 UTC) #9
Reilly Grant (use Gerrit)
Switch to UseCounter.h.
4 years, 4 months ago (2016-08-24 20:05:13 UTC) #10
Reilly Grant (use Gerrit)
On 2016/08/24 at 01:13:19, haraken wrote: > I'd prefer centralizing all UMA metrics in UseCounter.h ...
4 years, 4 months ago (2016-08-24 20:05:36 UTC) #11
Reilly Grant (use Gerrit)
Rebased.
4 years, 4 months ago (2016-08-24 20:25:26 UTC) #16
haraken
LGTM
4 years, 4 months ago (2016-08-24 22:54:17 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272563003/60001
4 years, 4 months ago (2016-08-24 23:30:42 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/245463)
4 years, 4 months ago (2016-08-24 23:49:53 UTC) #26
Reilly Grant (use Gerrit)
Rebased.
4 years, 4 months ago (2016-08-25 00:33:16 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272563003/80001
4 years, 4 months ago (2016-08-25 00:35:30 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/280694)
4 years, 4 months ago (2016-08-25 04:30:43 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272563003/80001
4 years, 4 months ago (2016-08-25 04:43:58 UTC) #34
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-08-25 09:07:08 UTC) #35
commit-bot: I haz the power
4 years, 4 months ago (2016-08-25 09:11:43 UTC) #37
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/9882e9ddab06dd2acc556707d0feb8c129a8b3c3
Cr-Commit-Position: refs/heads/master@{#414367}

Powered by Google App Engine
This is Rietveld 408576698