|
|
Created:
4 years, 4 months ago by Reilly Grant (use Gerrit) Modified:
4 years, 4 months ago CC:
asvitkine+watch_chromium.org, blink-reviews, chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd an UMA histogram for WebUSB function calls.
Each WebUSB function (on the USB and USBDevice IDL objects) is given a
histogram value that is recorded when the function is called.
BUG=492204
Committed: https://crrev.com/9882e9ddab06dd2acc556707d0feb8c129a8b3c3
Cr-Commit-Position: refs/heads/master@{#414367}
Patch Set 1 #Patch Set 2 : Make histogram names consistent. #
Total comments: 1
Patch Set 3 : Switch to UseCounter.h. #Patch Set 4 : Rebased. #Patch Set 5 : Rebased. #
Messages
Total messages: 37 (22 generated)
The CQ bit was checked by reillyg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
reillyg@chromium.org changed reviewers: + holte@chromium.org
Please take a look, this is the first time I've added a histogram in Blink and I want to be sure I'm doing it correctly.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
haraken@chromium.org changed reviewers: + haraken@chromium.org
https://codereview.chromium.org/2272563003/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/modules/webusb/USBMetrics.h (right): https://codereview.chromium.org/2272563003/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/webusb/USBMetrics.h:29: UsbDeviceReset = 15, I'd prefer centralizing all UMA metrics in UseCounter.h instead of adding localized metrics to each directory though.
histograms lgtm
Switch to UseCounter.h.
On 2016/08/24 at 01:13:19, haraken wrote: > I'd prefer centralizing all UMA metrics in UseCounter.h instead of adding localized metrics to each directory though. Done.
The CQ bit was checked by reillyg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Rebased.
The CQ bit was checked by reillyg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by reillyg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from holte@chromium.org Link to the patchset: https://codereview.chromium.org/2272563003/#ps60001 (title: "Rebased.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Rebased.
The CQ bit was checked by reillyg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org, holte@chromium.org Link to the patchset: https://codereview.chromium.org/2272563003/#ps80001 (title: "Rebased.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by reillyg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Add an UMA histogram for WebUSB function calls. Each WebUSB function (on the USB and USBDevice IDL objects) is given a histogram value that is recorded when the function is called. BUG=492204 ========== to ========== Add an UMA histogram for WebUSB function calls. Each WebUSB function (on the USB and USBDevice IDL objects) is given a histogram value that is recorded when the function is called. BUG=492204 Committed: https://crrev.com/9882e9ddab06dd2acc556707d0feb8c129a8b3c3 Cr-Commit-Position: refs/heads/master@{#414367} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/9882e9ddab06dd2acc556707d0feb8c129a8b3c3 Cr-Commit-Position: refs/heads/master@{#414367} |