MD WebUI: Use arrow keys for navigation in cr-shared-menu, close on tab

chrome/test/data/webui/cr_elements/cr_shared_menu_tests.js

Index: chrome/test/data/webui/cr_elements/cr_shared_menu_tests.js
diff --git a/chrome/test/data/webui/cr_elements/cr_shared_menu_tests.js b/chrome/test/data/webui/cr_elements/cr_shared_menu_tests.js
index b5ac54a50e53f35a5180091cca8b905db7af2758..4e32d39335f544119d43e54dad2af4a6ac2d009f 100644
--- a/chrome/test/data/webui/cr_elements/cr_shared_menu_tests.js
+++ b/chrome/test/data/webui/cr_elements/cr_shared_menu_tests.js
@@ -14,7 +14,9 @@ suite('cr-shared-menu', function() {
   function afterOpen(callback) {
     menu.addEventListener('iron-overlay-opened', function f() {

[Dan Beam, 2016/09/29 03:22:59]

btw, listenOnce() is now a thing:

https://cs.chromium.org/chromium/src/ui/webui/resources/js/util.js?q=listenOn...

[tsergeant, 2016/09/29 06:59:56]

Neat, done.

       menu.removeEventListener('iron-overlay-opened', f);
-      callback();
+      // paper-listbox applies focus after opening with microtask timing.
+      // Delay until that has happened:
+      setTimeout(callback, 0);
     });
   }
 
@@ -146,32 +148,48 @@ suite('cr-shared-menu', function() {
       });
     });
 
-    test('focus is trapped inside the menu', function(done) {
+    test('tab closes menu', function(done) {
       button.focus();
       MockInteractions.tap(button);
 
       afterOpen(function() {
-        // Simulate shift-tab on first element.
-        assertEquals(items[0], menu.shadowRoot.activeElement);
-        MockInteractions.pressAndReleaseKeyOn(items[0], 9, ['shift']);
-        assertEquals(items[2], menu.shadowRoot.activeElement);
+        MockInteractions.pressAndReleaseKeyOn(items[0], 9);
+        afterClose(function() {
+          // Focus should move to a different element, but we can't simulate
+          // the right events to test this.
+          done();
+        });
+      });
+    });
 
-        // Simulate tab on last element.
-        MockInteractions.pressAndReleaseKeyOn(items[2], 9);
-        assertEquals(items[0], menu.shadowRoot.activeElement);
+    test('shift-tab closes menu', function(done) {
+      button.focus();
+      MockInteractions.tap(button);
 
-        // Simulate shift-tab on first element.
-        assertEquals(items[0], menu.shadowRoot.activeElement);
+      afterOpen(function() {
         MockInteractions.pressAndReleaseKeyOn(items[0], 9, ['shift']);
-        assertEquals(items[2], menu.shadowRoot.activeElement);
+        afterClose(done);
+      });
+    });
 
-        // Simulate shift-tab on last element. This should simply cause the
-        // browser to focus the previous item in the tab order, since
-        // cr-shared-menu should not wrap in this case. However, we can't mimic
-        // native events from JS, so the focus won't actually move unless
-        // cr-shared--menu misbehaves.
-        MockInteractions.pressAndReleaseKeyOn(items[2], 9, ['shift']);
-        assertEquals(items[2], menu.shadowRoot.activeElement);
+    test('up and down change focus', function(done) {
+      button.focus();
+      MockInteractions.tap(button);
+
+      afterOpen(function() {
+        // Pressing down on first item goes to second item.
+        assertEquals(items[0], document.activeElement);
+        MockInteractions.pressAndReleaseKeyOn(items[0], 40);
+        assertEquals(items[1], document.activeElement);
+
+        // Pressing down twice more cycles back to first item.
+        MockInteractions.pressAndReleaseKeyOn(items[1], 40);
+        MockInteractions.pressAndReleaseKeyOn(items[2], 40);
+        assertEquals(items[0], document.activeElement);
+
+        // Pressing up cycles to last item.
+        MockInteractions.pressAndReleaseKeyOn(items[0], 38);
+        assertEquals(items[2], document.activeElement);
 
         done();
       });
@@ -193,6 +211,7 @@ suite('cr-shared-menu', function() {
 
       items[3] = document.createElement('button');
       items[3].disabled = true;
+      menu.appendChild(items[3]);
 
       items[4] = document.createElement('paper-item');
       items[4].hidden = true;
@@ -209,13 +228,13 @@ suite('cr-shared-menu', function() {
         assertEquals(items[1], menu.shadowRoot.activeElement);
 
         // The last two items are disabled or hidden, so they should be skipped
-        // too.
-        MockInteractions.pressAndReleaseKeyOn(items[1], 9, ['shift']);
+        // when pressing up.
+        MockInteractions.pressAndReleaseKeyOn(items[1], 38);
         assertEquals(items[2], menu.shadowRoot.activeElement);
 
-        // Simulate tab on last tabbable element to wrap to the first tabbable
-        // element again.
-        MockInteractions.pressAndReleaseKeyOn(items[2], 9);
+        // Simulate pressing down on last focusable element to wrap to first
+        // focusable element.
+        MockInteractions.pressAndReleaseKeyOn(items[2], 40);
         assertEquals(items[1], menu.shadowRoot.activeElement);
 
         done();