Blimp GoBack browser test

This is an initial Blimp integration test that exercises navigation history. The purpose is to test the integration with WebContentsImpl and NavigationControllerImpl, as well as the proper flow of Blimp's NavigationStateChangeMessage protobuf across the client-engine network connection.

The test visits two different web pages and then goes back to the first one.

Additional supporting changes:
* Moving some setup code from the initial LoadUrl test into SetUpOnMainThread.
* Helper method ExpectPageLoad, which sets mock expectations for a page load, and can be used with the helper method RunAndVerify to wait for Blimp to load a page.
* Always storing the latest page title when it changes on the client side, making it easier to assert about what page was most recently loaded.

Committed: https://crrev.com/b81ee930690de15fc68cfb0c17c413c973749f4c
Cr-Commit-Position: refs/heads/master@{#414755}

[Brian Goldman, 2016-08-24 23:36:27]

Description was changed from

==========
wip

BUG=
==========

to

==========
This an initial Blimp integration test that exercises navigation history. The
purpose is to test the integration with WebContentsImpl and
NavigationControllerImpl, as well as the proper flow of Blimp's
NavigationStateChangeMessage protobuf across the client-engine network
connection.

The test visits two different web pages and then goes back to the first one.

Additional supporting changes:
* Moving some setup code from the initial LoadPage test into SetUpOnMainThread.
* Helper method ExpectPageLoad, which sets mock expectations for a page load,
and can be used with the helper method RunAndVerify to wait for Blimp to load a
page.
* Always storing the latest page title when it changes on the client side,
making it easier to assert about what page was most recently loaded.

The Blimp browser test framework currently doesn't work properly with multiple
tests and the --single_process flag, so this change will break any use of
--single_process with the blimp_browsertests binary without the use of
--gtest_filter to specify a single test.
==========

[Brian Goldman, 2016-08-24 23:37:11]

Description was changed from

==========
This an initial Blimp integration test that exercises navigation history. The
purpose is to test the integration with WebContentsImpl and
NavigationControllerImpl, as well as the proper flow of Blimp's
NavigationStateChangeMessage protobuf across the client-engine network
connection.

The test visits two different web pages and then goes back to the first one.

Additional supporting changes:
* Moving some setup code from the initial LoadPage test into SetUpOnMainThread.
* Helper method ExpectPageLoad, which sets mock expectations for a page load,
and can be used with the helper method RunAndVerify to wait for Blimp to load a
page.
* Always storing the latest page title when it changes on the client side,
making it easier to assert about what page was most recently loaded.

The Blimp browser test framework currently doesn't work properly with multiple
tests and the --single_process flag, so this change will break any use of
--single_process with the blimp_browsertests binary without the use of
--gtest_filter to specify a single test.
==========

to

==========
This an initial Blimp integration test that exercises navigation history. The
purpose is to test the integration with WebContentsImpl and
NavigationControllerImpl, as well as the proper flow of Blimp's
NavigationStateChangeMessage protobuf across the client-engine network
connection.

The test visits two different web pages and then goes back to the first one.

Additional supporting changes:
* Moving some setup code from the initial LoadPage test into SetUpOnMainThread.
* Helper method ExpectPageLoad, which sets mock expectations for a page load,
and can be used with the helper method RunAndVerify to wait for Blimp to load a
page.
* Always storing the latest page title when it changes on the client side,
making it easier to assert about what page was most recently loaded.

The Blimp browser test framework currently doesn't work properly with multiple
tests and the --single_process flag, so this change will break any use of
--single_process with the blimp_browsertests binary unless you also use
--gtest_filter to specify a single test.
==========

[Brian Goldman, 2016-08-24 23:38:35]

bgoldman@chromium.org changed reviewers:
+ kmarshall@chromium.org

[Brian Goldman, 2016-08-24 23:42:34]

Description was changed from

==========
This an initial Blimp integration test that exercises navigation history. The
purpose is to test the integration with WebContentsImpl and
NavigationControllerImpl, as well as the proper flow of Blimp's
NavigationStateChangeMessage protobuf across the client-engine network
connection.

The test visits two different web pages and then goes back to the first one.

Additional supporting changes:
* Moving some setup code from the initial LoadPage test into SetUpOnMainThread.
* Helper method ExpectPageLoad, which sets mock expectations for a page load,
and can be used with the helper method RunAndVerify to wait for Blimp to load a
page.
* Always storing the latest page title when it changes on the client side,
making it easier to assert about what page was most recently loaded.

The Blimp browser test framework currently doesn't work properly with multiple
tests and the --single_process flag, so this change will break any use of
--single_process with the blimp_browsertests binary unless you also use
--gtest_filter to specify a single test.
==========

to

==========
This an initial Blimp integration test that exercises navigation history. The
purpose is to test the integration with WebContentsImpl and
NavigationControllerImpl, as well as the proper flow of Blimp's
NavigationStateChangeMessage protobuf across the client-engine network
connection.

The test visits two different web pages and then goes back to the first one.

Additional supporting changes:
* Moving some setup code from the initial LoadUrl test into SetUpOnMainThread.
* Helper method ExpectPageLoad, which sets mock expectations for a page load,
and can be used with the helper method RunAndVerify to wait for Blimp to load a
page.
* Always storing the latest page title when it changes on the client side,
making it easier to assert about what page was most recently loaded.

The Blimp browser test framework currently doesn't work properly with multiple
tests and the --single_process flag, so this change will break any use of
--single_process with the blimp_browsertests binary unless you also use
--gtest_filter to specify a single test.
==========

[Brian Goldman, 2016-08-24 23:52:58]

bgoldman@chromium.org changed reviewers:
+ leilei@chromium.org

[Brian Goldman, 2016-08-25 00:38:38]

Description was changed from

==========
This an initial Blimp integration test that exercises navigation history. The
purpose is to test the integration with WebContentsImpl and
NavigationControllerImpl, as well as the proper flow of Blimp's
NavigationStateChangeMessage protobuf across the client-engine network
connection.

The test visits two different web pages and then goes back to the first one.

Additional supporting changes:
* Moving some setup code from the initial LoadUrl test into SetUpOnMainThread.
* Helper method ExpectPageLoad, which sets mock expectations for a page load,
and can be used with the helper method RunAndVerify to wait for Blimp to load a
page.
* Always storing the latest page title when it changes on the client side,
making it easier to assert about what page was most recently loaded.

The Blimp browser test framework currently doesn't work properly with multiple
tests and the --single_process flag, so this change will break any use of
--single_process with the blimp_browsertests binary unless you also use
--gtest_filter to specify a single test.
==========

to

==========
This an initial Blimp integration test that exercises navigation history. The
purpose is to test the integration with WebContentsImpl and
NavigationControllerImpl, as well as the proper flow of Blimp's
NavigationStateChangeMessage protobuf across the client-engine network
connection.

The test visits two different web pages and then goes back to the first one.

Additional supporting changes:
* Moving some setup code from the initial LoadUrl test into SetUpOnMainThread.
* Helper method ExpectPageLoad, which sets mock expectations for a page load,
and can be used with the helper method RunAndVerify to wait for Blimp to load a
page.
* Always storing the latest page title when it changes on the client side,
making it easier to assert about what page was most recently loaded.
==========

[Brian Goldman, 2016-08-25 00:55:05]

Description was changed from

==========
This an initial Blimp integration test that exercises navigation history. The
purpose is to test the integration with WebContentsImpl and
NavigationControllerImpl, as well as the proper flow of Blimp's
NavigationStateChangeMessage protobuf across the client-engine network
connection.

The test visits two different web pages and then goes back to the first one.

Additional supporting changes:
* Moving some setup code from the initial LoadUrl test into SetUpOnMainThread.
* Helper method ExpectPageLoad, which sets mock expectations for a page load,
and can be used with the helper method RunAndVerify to wait for Blimp to load a
page.
* Always storing the latest page title when it changes on the client side,
making it easier to assert about what page was most recently loaded.
==========

to

==========
This is an initial Blimp integration test that exercises navigation history. The
purpose is to test the integration with WebContentsImpl and
NavigationControllerImpl, as well as the proper flow of Blimp's
NavigationStateChangeMessage protobuf across the client-engine network
connection.

The test visits two different web pages and then goes back to the first one.

Additional supporting changes:
* Moving some setup code from the initial LoadUrl test into SetUpOnMainThread.
* Helper method ExpectPageLoad, which sets mock expectations for a page load,
and can be used with the helper method RunAndVerify to wait for Blimp to load a
page.
* Always storing the latest page title when it changes on the client side,
making it easier to assert about what page was most recently loaded.
==========

[Kevin M, 2016-08-25 19:44:41]

lgtm - browser tests needn't run in --single_process mode.

https://codereview.chromium.org/2272513003/diff/80001/blimp/engine/browser_te...
File blimp/engine/browser_tests/engine_browsertest.cc (right):

https://codereview.chromium.org/2272513003/diff/80001/blimp/engine/browser_te...
blimp/engine/browser_tests/engine_browsertest.cc:72: void
NavigateToLocalUrl(std::string path) {
const std::string&

https://codereview.chromium.org/2272513003/diff/80001/blimp/engine/browser_te...
blimp/engine/browser_tests/engine_browsertest.cc:75: url.spec());
Odd indentation - run "git cl format"

[Brian Goldman, 2016-08-26 15:55:03]

https://codereview.chromium.org/2272513003/diff/80001/blimp/engine/browser_te...
File blimp/engine/browser_tests/engine_browsertest.cc (right):

https://codereview.chromium.org/2272513003/diff/80001/blimp/engine/browser_te...
blimp/engine/browser_tests/engine_browsertest.cc:72: void
NavigateToLocalUrl(std::string path) {
On 2016/08/25 19:44:41, Kevin M wrote:
> const std::string&

Done.

https://codereview.chromium.org/2272513003/diff/80001/blimp/engine/browser_te...
blimp/engine/browser_tests/engine_browsertest.cc:75: url.spec());
On 2016/08/25 19:44:41, Kevin M wrote:
> Odd indentation - run "git cl format"

I ran the command and it changed the indentation on a different line but not
this one. It looks fine to me, as well:
https://google.github.io/styleguide/cppguide.html#Function_Calls

[Brian Goldman, 2016-08-26 17:22:27]

The CQ bit was checked by bgoldman@chromium.org

[Brian Goldman, 2016-08-26 17:22:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
kmarshall@chromium.org
Link to the patchset: https://codereview.chromium.org/2272513003/#ps100001
(title: "review changes")

[commit-bot: I haz the power, 2016-08-26 17:22:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 18:29:24]

Description was changed from

==========
This is an initial Blimp integration test that exercises navigation history. The
purpose is to test the integration with WebContentsImpl and
NavigationControllerImpl, as well as the proper flow of Blimp's
NavigationStateChangeMessage protobuf across the client-engine network
connection.

The test visits two different web pages and then goes back to the first one.

Additional supporting changes:
* Moving some setup code from the initial LoadUrl test into SetUpOnMainThread.
* Helper method ExpectPageLoad, which sets mock expectations for a page load,
and can be used with the helper method RunAndVerify to wait for Blimp to load a
page.
* Always storing the latest page title when it changes on the client side,
making it easier to assert about what page was most recently loaded.
==========

to

==========
This is an initial Blimp integration test that exercises navigation history. The
purpose is to test the integration with WebContentsImpl and
NavigationControllerImpl, as well as the proper flow of Blimp's
NavigationStateChangeMessage protobuf across the client-engine network
connection.

The test visits two different web pages and then goes back to the first one.

Additional supporting changes:
* Moving some setup code from the initial LoadUrl test into SetUpOnMainThread.
* Helper method ExpectPageLoad, which sets mock expectations for a page load,
and can be used with the helper method RunAndVerify to wait for Blimp to load a
page.
* Always storing the latest page title when it changes on the client side,
making it easier to assert about what page was most recently loaded.
==========

[commit-bot: I haz the power, 2016-08-26 18:29:26]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-08-26 18:32:59]

Description was changed from

==========
This is an initial Blimp integration test that exercises navigation history. The
purpose is to test the integration with WebContentsImpl and
NavigationControllerImpl, as well as the proper flow of Blimp's
NavigationStateChangeMessage protobuf across the client-engine network
connection.

The test visits two different web pages and then goes back to the first one.

Additional supporting changes:
* Moving some setup code from the initial LoadUrl test into SetUpOnMainThread.
* Helper method ExpectPageLoad, which sets mock expectations for a page load,
and can be used with the helper method RunAndVerify to wait for Blimp to load a
page.
* Always storing the latest page title when it changes on the client side,
making it easier to assert about what page was most recently loaded.
==========

to

==========
This is an initial Blimp integration test that exercises navigation history. The
purpose is to test the integration with WebContentsImpl and
NavigationControllerImpl, as well as the proper flow of Blimp's
NavigationStateChangeMessage protobuf across the client-engine network
connection.

The test visits two different web pages and then goes back to the first one.

Additional supporting changes:
* Moving some setup code from the initial LoadUrl test into SetUpOnMainThread.
* Helper method ExpectPageLoad, which sets mock expectations for a page load,
and can be used with the helper method RunAndVerify to wait for Blimp to load a
page.
* Always storing the latest page title when it changes on the client side,
making it easier to assert about what page was most recently loaded.

Committed: https://crrev.com/b81ee930690de15fc68cfb0c17c413c973749f4c
Cr-Commit-Position: refs/heads/master@{#414755}
==========

[commit-bot: I haz the power, 2016-08-26 18:33:01]

Patchset 6 (id:??) landed as
https://crrev.com/b81ee930690de15fc68cfb0c17c413c973749f4c
Cr-Commit-Position: refs/heads/master@{#414755}