Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2272513002: Documentation: Clarify that runtime.sendMessage does not notify itself (Closed)

Created:
4 years, 4 months ago by robwu
Modified:
4 years, 4 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Documentation: Clarify that runtime.sendMessage does not notify itself BUG=628083 Committed: https://crrev.com/d93b830a957594d7ae309096d3dca344bd9abffd Cr-Commit-Position: refs/heads/master@{#414114}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Documentation: Clarify that runtime.sendMessage does not notify itself #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M extensions/common/api/runtime.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
robwu
4 years, 4 months ago (2016-08-23 04:31:21 UTC) #2
Devlin
https://codereview.chromium.org/2272513002/diff/1/chrome/common/extensions/docs/templates/articles/nativeMessaging.html File chrome/common/extensions/docs/templates/articles/nativeMessaging.html (right): https://codereview.chromium.org/2272513002/diff/1/chrome/common/extensions/docs/templates/articles/nativeMessaging.html#newcode50 chrome/common/extensions/docs/templates/articles/nativeMessaging.html:50: absolute, on Linux and OSX the path can be ...
4 years, 4 months ago (2016-08-23 16:30:34 UTC) #3
robwu
https://codereview.chromium.org/2272513002/diff/1/chrome/common/extensions/docs/templates/articles/nativeMessaging.html File chrome/common/extensions/docs/templates/articles/nativeMessaging.html (right): https://codereview.chromium.org/2272513002/diff/1/chrome/common/extensions/docs/templates/articles/nativeMessaging.html#newcode50 chrome/common/extensions/docs/templates/articles/nativeMessaging.html:50: absolute, on Linux and OSX the path can be ...
4 years, 4 months ago (2016-08-24 06:49:42 UTC) #5
Devlin
lgtm
4 years, 4 months ago (2016-08-24 16:01:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272513002/20001
4 years, 4 months ago (2016-08-24 17:19:00 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-24 18:46:45 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 18:48:50 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d93b830a957594d7ae309096d3dca344bd9abffd
Cr-Commit-Position: refs/heads/master@{#414114}

Powered by Google App Engine
This is Rietveld 408576698