Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 2272503002: [DevTools] Protocol version 1.2. (Closed)

Created:
4 years, 4 months ago by dgozman
Modified:
4 years, 3 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, apavlov+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Protocol version 1.2. Moving most of Schema, Runtime, Debugger, Profiler and Emulation out of experimental. BUG=635947 Committed: https://crrev.com/420512c42cfa7ff5260fc6ebc7ae656447cd3b67 Cr-Commit-Position: refs/heads/master@{#414241}

Patch Set 1 #

Total comments: 3

Patch Set 2 : more experimental #

Messages

Total messages: 17 (10 generated)
dgozman
Could you please take a look?
4 years, 4 months ago (2016-08-23 02:19:18 UTC) #2
kozy
lgtm for js_protocol.json related to Runtime.
4 years, 4 months ago (2016-08-23 02:48:56 UTC) #3
alph
lgtm for Profiler
4 years, 4 months ago (2016-08-23 19:19:12 UTC) #4
pfeldman
lgtm https://codereview.chromium.org/2272503002/diff/1/third_party/WebKit/Source/core/inspector/browser_protocol.json File third_party/WebKit/Source/core/inspector/browser_protocol.json (left): https://codereview.chromium.org/2272503002/diff/1/third_party/WebKit/Source/core/inspector/browser_protocol.json#oldcode1278 third_party/WebKit/Source/core/inspector/browser_protocol.json:1278: "name": "emulateNetworkConditions", Why is this not emulation? https://codereview.chromium.org/2272503002/diff/1/third_party/WebKit/Source/core/inspector/browser_protocol.json#oldcode2461 ...
4 years, 4 months ago (2016-08-24 00:50:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272503002/20001
4 years, 3 months ago (2016-08-24 22:59:47 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-25 01:10:48 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 01:15:03 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/420512c42cfa7ff5260fc6ebc7ae656447cd3b67
Cr-Commit-Position: refs/heads/master@{#414241}

Powered by Google App Engine
This is Rietveld 408576698