net/cert/internal/trust_store.h - Issue 2272493002: Add TrustStoreNSS and TrustStoreCollection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/internal/trust_store.h

Issue 2272493002: Add TrustStoreNSS and TrustStoreCollection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cert-trust-store-interface3-nss

Patch Set: review changes Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/cert/internal/path_builder.cc ('k') | net/cert/internal/trust_store_collection.h » ('j') | net/cert/internal/trust_store_collection_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/cert/internal/trust_store.h

diff --git a/net/cert/internal/trust_store.h b/net/cert/internal/trust_store.h

index 2d02ac17c99cba356f4221fe94ccf43511226910..8422fd5c96a7b805a925203ee001613d62fe4ffb 100644

--- a/net/cert/internal/trust_store.h

+++ b/net/cert/internal/trust_store.h

@@ -140,7 +140,7 @@ class NET_EXPORT TrustStore {

// when results are available. The Request may be destroyed to cancel

// the callback if it has not occurred yet.

virtual void FindTrustAnchorsForCert(

- const ParsedCertificate* cert,

+ const scoped_refptr<ParsedCertificate>& cert,

Ryan Sleevi 2016/08/31 20:50:39 https://chromium.googlesource.com/chromium/src/+/m

mattm 2016/09/01 00:59:02 Yea, this does go against the style guide. But fol

const TrustAnchorsCallback& callback,

TrustAnchors* synchronous_matches,

std::unique_ptr<Request>* out_req) const = 0;

« no previous file with comments | « net/cert/internal/path_builder.cc ('k') | net/cert/internal/trust_store_collection.h » ('j') | net/cert/internal/trust_store_collection_unittest.cc » ('J')