Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2272423004: Remove pixel config fallback - failing is a better option. (Closed)

Created:
4 years, 3 months ago by Brian Osman
Modified:
4 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove pixel config fallback - failing is a better option. This produces surprising results in some cases. For example: Attempt to make an F16 SkSurface on ANGLE. We can't render to F16, but this succeeds and gives you back an N32 surface instead. Ran all tests and GMs in DM on ANGLE (where this is most likely to be an issue). No problems. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2272423004 Committed: https://skia.googlesource.com/skia/+/464a7d6f95c9acef829606b7e29ed8d1bef8842c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M src/gpu/SkGpuDevice.cpp View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Brian Osman
4 years, 3 months ago (2016-08-25 15:18:22 UTC) #5
bsalomon
lgtm
4 years, 3 months ago (2016-08-25 15:31:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272423004/1
4 years, 3 months ago (2016-08-25 15:51:11 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 15:55:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/464a7d6f95c9acef829606b7e29ed8d1bef8842c

Powered by Google App Engine
This is Rietveld 408576698