Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2272413002:
Update the V8 version for Chromium branch 54. (Closed)
|
Created:
4 years, 3 months ago by Michael Hablich Modified:
4 years, 3 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate the V8 version for Chromium branch 54.
This is a roll-back to 5.4.500.1. This is the most stable candidate out of the latest Canaries.
If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back.
When in doubt please try to contact the committer and reviewers of this CL before reverting it.
NOTRY because of flaky bots.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org
NOTRY=true
Committed: https://crrev.com/24bf4ca32d44df5d9940645ab45435a6459916c2
Cr-Commit-Position: refs/heads/master@{#414416}
Patch Set 1 #Patch Set 2 : Rebase #Messages
Total messages: 17 (10 generated)
The CQ bit was checked by hablich@chromium.org
The CQ bit was unchecked by hablich@chromium.org
Description was changed from ========== Update the V8 version for Chromium branch 54. This is a roll-back to 5.4.500.1. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. TBR=machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org ========== to ========== Update the V8 version for Chromium branch 54. This is a roll-back to 5.4.500.1. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org ==========
The CQ bit was checked by hablich@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by hablich@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Update the V8 version for Chromium branch 54. This is a roll-back to 5.4.500.1. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org ========== to ========== Update the V8 version for Chromium branch 54. This is a roll-back to 5.4.500.1. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. NOTRY because of flaky bots. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org NOTRY=true ==========
The CQ bit was checked by hablich@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Update the V8 version for Chromium branch 54. This is a roll-back to 5.4.500.1. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. NOTRY because of flaky bots. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org NOTRY=true ========== to ========== Update the V8 version for Chromium branch 54. This is a roll-back to 5.4.500.1. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. NOTRY because of flaky bots. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Update the V8 version for Chromium branch 54. This is a roll-back to 5.4.500.1. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. NOTRY because of flaky bots. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org NOTRY=true ========== to ========== Update the V8 version for Chromium branch 54. This is a roll-back to 5.4.500.1. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. NOTRY because of flaky bots. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org NOTRY=true Committed: https://crrev.com/24bf4ca32d44df5d9940645ab45435a6459916c2 Cr-Commit-Position: refs/heads/master@{#414416} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/24bf4ca32d44df5d9940645ab45435a6459916c2 Cr-Commit-Position: refs/heads/master@{#414416}
Message was sent while issue was closed.
lgtm |
