Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2272373002: Remove deprecated Resource class from dart:core. (Closed)

Created:
4 years, 3 months ago by Lasse Reichstein Nielsen
Modified:
4 years, 3 months ago
Reviewers:
mit, floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Revert #

Patch Set 3 : Reapply #

Patch Set 4 : Remove patch files #

Patch Set 5 : Remove a resource test in tests/html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -42 lines) Patch
D tests/html/resource_data.txt View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
D tests/html/resource_http_test.dart View 1 2 3 4 1 chunk +0 lines, -41 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Lasse Reichstein Nielsen
4 years, 3 months ago (2016-08-25 08:41:18 UTC) #2
mit
On 2016/08/25 08:41:18, Lasse Reichstein Nielsen wrote: lgtm
4 years, 3 months ago (2016-08-25 11:44:33 UTC) #3
floitsch
LGTM.
4 years, 3 months ago (2016-08-25 11:45:37 UTC) #4
Lasse Reichstein Nielsen
Committed patchset #1 (id:1) manually as f61143153a9aee2738bf3bf83d447e016f41e653 (presubmit successful).
4 years, 3 months ago (2016-08-26 08:32:04 UTC) #6
Lasse Reichstein Nielsen
Committed patchset #2 (id:20001) manually as 35437dda1f8b120d4b241a0a4925071a16f42442 (presubmit successful).
4 years, 3 months ago (2016-08-26 08:51:26 UTC) #8
Lasse Reichstein Nielsen
Committed patchset #4 (id:60001) manually as 99ec987a0932920fd82c0fcf493d968e2996b8e7 (presubmit successful).
4 years, 3 months ago (2016-08-26 09:58:16 UTC) #10
Lasse Reichstein Nielsen
4 years, 3 months ago (2016-08-26 11:48:28 UTC) #12
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
a3a28f9e9574fc65a6c73f47aa6fcbb63bb9aa62 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698