Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2272343002: Introduce DragController::hasCaretIn() (Closed)

Created:
4 years, 3 months ago by yosin_UTC9
Modified:
4 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce DragController::hasCaretIn() This patch introduces |DragController::hasCaretIn()| as replacement of |DragController::caretLayoutObject()| and |DragController::isContentEditable()| to provide high-level API for improving code health. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/9f661daee719dff656ba327e07805f0101af0165 Cr-Commit-Position: refs/heads/master@{#414381}

Patch Set 1 : 2016-08-25T15:59:17 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M third_party/WebKit/Source/core/editing/DragCaretController.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/DragCaretController.cpp View 3 chunks +14 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
yosin_UTC9
PTAL
4 years, 3 months ago (2016-08-25 07:51:23 UTC) #5
tkent
lgtm
4 years, 3 months ago (2016-08-25 07:55:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272343002/1
4 years, 3 months ago (2016-08-25 07:59:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 10:24:51 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 10:26:36 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f661daee719dff656ba327e07805f0101af0165
Cr-Commit-Position: refs/heads/master@{#414381}

Powered by Google App Engine
This is Rietveld 408576698