net/proxy/proxy_resolver_perftest.cc - Issue 227233006: Make net use v8 through gin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_resolver_perftest.cc

Issue 227233006: Make net use v8 through gin (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: updates Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/proxy/proxy_resolver_perftest.cc

diff --git a/net/proxy/proxy_resolver_perftest.cc b/net/proxy/proxy_resolver_perftest.cc

index 12ffd1bd91ac53312d0493846033e8599b9d501f..10dc72863ec1623fb02de55ca1d29ab9448c05c3 100644

--- a/net/proxy/proxy_resolver_perftest.cc

+++ b/net/proxy/proxy_resolver_perftest.cc

@@ -218,8 +218,7 @@ class MockJSBindings : public net::ProxyResolverV8::JSBindings {

};

TEST(ProxyResolverPerfTest, ProxyResolverV8) {

- // This has to be done on the main thread.

- net::ProxyResolverV8::RememberDefaultIsolate();

+ net::ProxyResolverV8::CreateIsolate();

MockJSBindings js_bindings;

net::ProxyResolverV8 resolver;