Allow Safe Browsing Saresource Filter to distinguish between different lists.

components/subresource_filter/core/browser/subresource_filter_features.cc

Index: components/subresource_filter/core/browser/subresource_filter_features.cc
diff --git a/components/subresource_filter/core/browser/subresource_filter_features.cc b/components/subresource_filter/core/browser/subresource_filter_features.cc
index a0dea3959a6db787c5a27ba211922ebcacfe608a..51d19c93b9dceb01d39f83d5528245a4caff051c 100644
--- a/components/subresource_filter/core/browser/subresource_filter_features.cc
+++ b/components/subresource_filter/core/browser/subresource_filter_features.cc
@@ -6,6 +6,7 @@
 
 #include <string>
 
+#include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "components/variations/variations_associated_data.h"
 
@@ -24,6 +25,11 @@ const char kActivationScopeAllSites[] = "all_sites";
 const char kActivationScopeActivationList[] = "activation_list";
 const char kActivationScopeNoSites[] = "no_sites";
 
+const char kActivationListsParameterName[] = "activation_lists";
+const char kActivationListSocialEngAdsIntestitial[] =
+    "social_eng_ads_intertitial";
+const char kActivationListPhishingInterstitial[] = "phishing_interstitial";
+
 ActivationState GetMaximumActivationState() {
   std::string activation_state = variations::GetVariationParamValueByFeature(
       kSafeBrowsingSubresourceFilter, kActivationStateParameterName);
@@ -45,4 +51,18 @@ ActivationScope GetCurrentActivationScope() {
   return ActivationScope::NO_SITES;
 }
 
+ActivationList GetCurrentActivationList() {
+  std::string activation_lists = variations::GetVariationParamValueByFeature(
+      kSafeBrowsingSubresourceFilter, kActivationListsParameterName);
+  for (const std::string& activation_list :
+       base::SplitString(activation_lists, ",", base::TRIM_WHITESPACE,

[engedy, 2016/08/25 21:32:54]

Let's use SplitStringPiece() here to avoid copies.  Did you check that
comma-separated values can be input on the command line?

[melandory, 2016/08/26 15:06:10]

Done.

+                         base::SPLIT_WANT_ALL)) {

[engedy, 2016/08/25 21:32:54]

nit: SPLIT_WANT_NONEMPTY (not that it matters)

[melandory, 2016/08/26 15:06:10]

Done.

+    if (base::LowerCaseEqualsASCII(activation_list,
+                                   kActivationListPhishingInterstitial)) {
+      return ActivationList::PHISHING_INTERSTITIAL;
+    }
+  }
+  return ActivationList::SOCIAL_ENG_ADS_INTERSTITIAL;
+}
+
 }  // namespace subresource_filter