components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc - Issue 2272323002: Allow Safe Browsing Saresource Filter to distinguish between different lists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

Issue 2272323002: Allow Safe Browsing Saresource Filter to distinguish between different lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Allow Safe Browsing Saresource Filter to distinguish between different lists. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc ('K') | « components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc ('k') | components/subresource_filter/content/browser/subresource_filter_navigation_throttle_unittests.cc » ('j') | components/subresource_filter/core/browser/subresource_filter_features.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

diff --git a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

index 7312028ebefdbb43c1d335269164fede31921426..62509f272691176430305838121e2e33dec80322 100644

--- a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

+++ b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

@@ -98,7 +98,7 @@ class ContentSubresourceFilterDriverFactoryTest

void BlacklistURLWithRedirects(const GURL& url,

const std::vector<GURL>& redirects) {

factory()->OnMainResourceMatchedSafeBrowsingBlacklist(

- url, redirects,

+ url, redirects, safe_browsing::SB_THREAT_TYPE_URL_PHISHING,

safe_browsing::ThreatPatternType::SOCIAL_ENGINEERING_ADS);

}

@@ -243,7 +243,8 @@ TEST_P(ContentSubresourceFilterDriverFactoryThreatTypeTest, NonSocEngHit) {

const GURL test_url("https://example.com/nonsoceng?q=engsocnon");

factory()->OnMainResourceMatchedSafeBrowsingBlacklist(

- GURL(test_url), std::vector<GURL>(), GetParam());

+ GURL(test_url), std::vector<GURL>(),

+ safe_browsing::SB_THREAT_TYPE_URL_PHISHING, GetParam());

EXPECT_EQ(0U, factory()->activation_set().size());

EXPECT_FALSE(factory()->ShouldActivateForURL(GURL(test_url)));

EXPECT_FALSE(