Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Unified Diff: components/subresource_filter/core/browser/subresource_filter_features_test_support.cc

Issue 2272323002: Allow Safe Browsing Saresource Filter to distinguish between different lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix safe_browsing_service_browsertest Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/subresource_filter/core/browser/subresource_filter_features_test_support.cc
diff --git a/components/subresource_filter/core/browser/subresource_filter_features_test_support.cc b/components/subresource_filter/core/browser/subresource_filter_features_test_support.cc
index 997732630691b77f01a1b0193260f5ca3307ea89..38cd2185eedb24601c9f80e77a43af057b7c26a0 100644
--- a/components/subresource_filter/core/browser/subresource_filter_features_test_support.cc
+++ b/components/subresource_filter/core/browser/subresource_filter_features_test_support.cc
@@ -23,12 +23,23 @@ const char kTestExperimentGroupName[] = "GroupNameShouldNotMatter";
ScopedSubresourceFilterFeatureToggle::ScopedSubresourceFilterFeatureToggle(
base::FeatureList::OverrideState feature_state,
const std::string& maximum_activation_state,
- const std::string& activation_scope) {
+ const std::string& activation_scope)
+ : ScopedSubresourceFilterFeatureToggle(feature_state,
+ maximum_activation_state,
+ activation_scope,
+ std::string()) {}
+
+ScopedSubresourceFilterFeatureToggle::ScopedSubresourceFilterFeatureToggle(
+ base::FeatureList::OverrideState feature_state,
+ const std::string& maximum_activation_state,
+ const std::string& activation_scope,
+ const std::string& activation_lists) {
variations::testing::ClearAllVariationParams();
std::map<std::string, std::string> variation_params;
variation_params[kActivationStateParameterName] = maximum_activation_state;
variation_params[kActivationScopeParameterName] = activation_scope;
+ variation_params[kActivationListsParameterName] = activation_lists;
EXPECT_TRUE(variations::AssociateVariationParams(
kTestFieldTrialName, kTestExperimentGroupName, variation_params));

Powered by Google App Engine
This is Rietveld 408576698