chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc - Issue 2272323002: Allow Safe Browsing Saresource Filter to distinguish between different lists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc

Issue 2272323002: Allow Safe Browsing Saresource Filter to distinguish between different lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix safe_browsing_service_browsertest Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/safe_browsing_resource_throttle.cc ('k') | components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h » ('j') | components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc b/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc

index 4797dffd0a52f73c33387096321d7f66be6a737a..9b669989d661f4a5871d5d0f4c1cb2d8ddd1ed6a 100644

--- a/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc

@@ -56,6 +56,8 @@

#include "components/safe_browsing_db/util.h"

#include "components/safe_browsing_db/v4_protocol_manager_util.h"

#include "components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h"

+#include "components/subresource_filter/core/browser/subresource_filter_features.h"

+#include "components/subresource_filter/core/browser/subresource_filter_features_test_support.h"

#include "content/public/browser/interstitial_page.h"

#include "content/public/browser/navigation_entry.h"

#include "content/public/browser/render_frame_host.h"

@@ -899,6 +901,12 @@ IN_PROC_BROWSER_TEST_F(SafeBrowsingServiceTest, MainFrameHitWithReferrer) {

IN_PROC_BROWSER_TEST_F(SafeBrowsingServiceTest,

SocEngReportingBlacklistNotEmpty) {

+ subresource_filter::testing::ScopedSubresourceFilterFeatureToggle

+ scoped_feature_toggle(

+ base::FeatureList::OVERRIDE_ENABLE_FEATURE,

+ subresource_filter::kActivationStateEnabled,

+ subresource_filter::kActivationScopeNoSites,

+ subresource_filter::kActivationListSocialEngineeringAdsInterstitial);

// Tests that when Safe Browsing gets hit which is corresponding to the

// SOCIAL_ENGINEERING_ADS threat type, then URL is added to the Subresource

// Filter.