Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2272313004: [layoutng] Rename struct members to match style guide (Closed)

Created:
4 years, 3 months ago by cbiesinger
Modified:
4 years, 3 months ago
Reviewers:
ikilpatrick, eae
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[layoutng] Rename struct members to match style guide This was focused on ng_units and ng_margin_strut, though I also updated some more variables in ng_block_layout_algorithm. https://google.github.io/styleguide/cppguide.html#Variable_Names R=ikilpatrick@chromium.org,eae@chromium.org BUG=635619 NOTRY=true Committed: https://crrev.com/b2a706bf1f9886fa6c91dc23b7dc4bc5c2c2498d Cr-Commit-Position: refs/heads/master@{#414483}

Patch Set 1 #

Messages

Total messages: 17 (10 generated)
cbiesinger
4 years, 3 months ago (2016-08-25 16:17:34 UTC) #1
ikilpatrick
lgtm
4 years, 3 months ago (2016-08-25 16:24:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272313004/1
4 years, 3 months ago (2016-08-25 16:25:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272313004/1
4 years, 3 months ago (2016-08-25 18:24:10 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 18:28:44 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b2a706bf1f9886fa6c91dc23b7dc4bc5c2c2498d Cr-Commit-Position: refs/heads/master@{#414483}
4 years, 3 months ago (2016-08-25 18:30:02 UTC) #16
eae
4 years, 3 months ago (2016-08-25 18:41:32 UTC) #17
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698