Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22723004: Get rid of webkit/plugins/plugin_constants.* and move them to content/public/common/content_constan… (Closed)

Created:
7 years, 4 months ago by jam
Modified:
7 years, 4 months ago
Reviewers:
scottmg
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Get rid of webkit/plugins/plugin_constants.* and move them to content/public/common/content_constants. This allows us to delete webkit_plugins.gyp and webkit/plugins. BUG=265753 R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216553

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -185 lines) Patch
M chrome/browser/chrome_plugin_browsertest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 1 2 3 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/pepper_flash_settings_manager.cc View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 2 3 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/flash_ui.cc View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/version_handler.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_content_client.cc View 1 2 3 4 chunks +8 lines, -9 lines 0 comments Download
M chrome/renderer/plugins/plugin_placeholder.cc View 1 2 3 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/renderer/plugins/plugin_uma.cc View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/test/ppapi/ppapi_test.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/plugin_data_remover_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/web_contents/debug_urls.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/plugin_instance.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/webplugin_delegate_impl_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/webplugin_delegate_impl_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/content_constants_internal.h View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M content/common/content_constants_internal.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/content_plugin.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_renderer.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M content/public/common/content_constants.h View 1 chunk +8 lines, -0 lines 0 comments Download
M content/public/common/content_constants.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M content/renderer/npapi/webplugin_delegate_proxy.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/npapi/webplugin_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 3 chunks +1 line, -2 lines 0 comments Download
D webkit/plugins/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D webkit/plugins/plugin_constants.h View 1 chunk +0 lines, -24 lines 0 comments Download
D webkit/plugins/plugin_constants.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D webkit/plugins/plugin_switches.h View 1 chunk +0 lines, -18 lines 0 comments Download
D webkit/plugins/plugin_switches.cc View 1 chunk +0 lines, -18 lines 0 comments Download
D webkit/plugins/webkit_plugins.gyp View 1 chunk +0 lines, -51 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
7 years, 4 months ago (2013-08-09 01:28:16 UTC) #1
scottmg
7 years, 4 months ago (2013-08-09 01:53:41 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698