Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2272283002: idl_compiler: Remove __getstate__ and __setstate__ from IdlArgument (Closed)

Created:
4 years, 3 months ago by bashi
Modified:
4 years, 3 months ago
Reviewers:
haraken, lkawai, peria, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

idl_compiler: Remove __getstate__ and __setstate__ from IdlArgument The pickle protocol uses __dict__ if __getstate__ and __setstate__ aren't defined. Using __dict__ is enough for IdlArgument. BUG=569301 Committed: https://crrev.com/e2a4246542c9e1d652123a48c89bcb8a231bae23 Cr-Commit-Position: refs/heads/master@{#414355}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M third_party/WebKit/Source/bindings/scripts/idl_definitions.py View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
bashi
PTAL We need to make IdlArgument picklable to create bindings for callback functions.
4 years, 3 months ago (2016-08-25 04:54:43 UTC) #4
haraken
LGTM
4 years, 3 months ago (2016-08-25 04:55:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272283002/1
4 years, 3 months ago (2016-08-25 04:56:38 UTC) #8
peria
lgtm
4 years, 3 months ago (2016-08-25 05:04:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 08:11:20 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 08:13:04 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e2a4246542c9e1d652123a48c89bcb8a231bae23
Cr-Commit-Position: refs/heads/master@{#414355}

Powered by Google App Engine
This is Rietveld 408576698