Desktop Chrome OS: Build with precise sysroot (Reland)

build/linux/sysroot_scripts/install-sysroot.py

 #!/usr/bin/env python
 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Install Debian sysroots for building chromium.
 """
 
 # The sysroot is needed to ensure that binaries will run on Debian Wheezy,
 # the oldest supported linux distribution. For ARM64 linux, we have Debian
@@ skipping 17 matching lines @@
 
 SCRIPT_DIR = os.path.dirname(os.path.abspath(__file__))
 sys.path.append(os.path.dirname(os.path.dirname(SCRIPT_DIR)))
 import detect_host_arch
 import gyp_chromium
 import gyp_environment
 
 
 URL_PREFIX = 'https://commondatastorage.googleapis.com'
 URL_PATH = 'chrome-linux-sysroot/toolchain'
-REVISION_AMD64 = '24f935a3d8cdfcdfbabd23928a42304b1ffc52ba'
-REVISION_ARM = '24f935a3d8cdfcdfbabd23928a42304b1ffc52ba'
-REVISION_ARM64 = '24f935a3d8cdfcdfbabd23928a42304b1ffc52ba'
-REVISION_I386 = '24f935a3d8cdfcdfbabd23928a42304b1ffc52ba'
-REVISION_MIPS = '24f935a3d8cdfcdfbabd23928a42304b1ffc52ba'
-TARBALL_AMD64 = 'debian_wheezy_amd64_sysroot.tgz'
-TARBALL_ARM = 'debian_wheezy_arm_sysroot.tgz'
-TARBALL_ARM64 = 'debian_jessie_arm64_sysroot.tgz'
-TARBALL_I386 = 'debian_wheezy_i386_sysroot.tgz'
-TARBALL_MIPS = 'debian_wheezy_mips_sysroot.tgz'
-TARBALL_AMD64_SHA1SUM = 'a7f3df28b02799fbd7675c2ab24f1924c104c0ee'
-TARBALL_ARM_SHA1SUM = '2df01b8173a363977daf04e176b8c7dba5b0b933'
-TARBALL_ARM64_SHA1SUM = 'df9270e00c258e6cd80f8172b1bfa39aafc4756f'
-TARBALL_I386_SHA1SUM = 'e2c7131fa5f711de28c37fd9442e77d32abfb3ff'
-TARBALL_MIPS_SHA1SUM = '22fe7b45b144691aeb515083025f0fceb131d724'
-SYSROOT_DIR_AMD64 = 'debian_wheezy_amd64-sysroot'
-SYSROOT_DIR_ARM = 'debian_wheezy_arm-sysroot'
-SYSROOT_DIR_ARM64 = 'debian_jessie_arm64-sysroot'
-SYSROOT_DIR_I386 = 'debian_wheezy_i386-sysroot'
-SYSROOT_DIR_MIPS = 'debian_wheezy_mips-sysroot'
+
+sysroots = {

[Tom (Use chromium acct), 2016/08/25 03:09:56]

Not sure if this is the most pythonic way to do this

[Dirk Pranke, 2016/08/25 03:27:22]

Nit: It's a constant, so, SYSROOTS. Otherwise, yes, that's fine.

[Tom (Use chromium acct), 2016/08/25 18:28:51]

Done.

+    ('Wheezy', 'amd64'): {
+        'Revision' : '24f935a3d8cdfcdfbabd23928a42304b1ffc52ba',
+        'Tarball' : 'debian_wheezy_amd64_sysroot.tgz',
+        'Sha1Sum' : 'a7f3df28b02799fbd7675c2ab24f1924c104c0ee',
+        'SysrootDir' : 'debian_wheezy_amd64-sysroot'
+    },
+    ('Wheezy', 'arm'): {
+        'Revision' : '24f935a3d8cdfcdfbabd23928a42304b1ffc52ba',
+        'Tarball' : 'debian_wheezy_arm_sysroot.tgz',
+        'Sha1Sum' : '2df01b8173a363977daf04e176b8c7dba5b0b933',
+        'SysrootDir' : 'debian_wheezy_arm-sysroot'
+    },
+    ('Wheezy', 'i386'): {
+        'Revision' : '24f935a3d8cdfcdfbabd23928a42304b1ffc52ba',
+        'Tarball' : 'debian_wheezy_i386_sysroot.tgz',
+        'Sha1Sum' : 'e2c7131fa5f711de28c37fd9442e77d32abfb3ff',
+        'SysrootDir' : 'debian_wheezy_i386-sysroot'
+    },
+    ('Wheezy', 'mips'): {
+        'Revision' : '24f935a3d8cdfcdfbabd23928a42304b1ffc52ba',
+        'Tarball' : 'debian_wheezy_mips_sysroot.tgz',
+        'Sha1Sum' : '22fe7b45b144691aeb515083025f0fceb131d724',
+        'SysrootDir' : 'debian_wheezy_mips-sysroot'
+    },
+    ('Jessie', 'arm64'): {
+        'Revision' : '24f935a3d8cdfcdfbabd23928a42304b1ffc52ba',
+        'Tarball' : 'debian_jessie_arm64_sysroot.tgz',
+        'Sha1Sum' : 'df9270e00c258e6cd80f8172b1bfa39aafc4756f',
+        'SysrootDir' : 'debian_jessie_arm64-sysroot'
+    },
+    ('Precise', 'amd64'): {
+        'Revision' : '24f935a3d8cdfcdfbabd23928a42304b1ffc52ba',
+        'Tarball' : 'ubuntu_precise_amd64_sysroot.tgz',
+        'Sha1Sum' : '67985675e64e1d3cf6574088f36f89092ae9e86b',
+        'SysrootDir' : 'ubuntu_precise_amd64-sysroot'
+    }
+}
 
 valid_archs = ('arm', 'arm64', 'i386', 'amd64', 'mips')
 
 
 class Error(Exception):
   pass
 
 
 def GetSha1(filename):
   sha1 = hashlib.sha1()
@@ skipping 10 matching lines @@
 def DetectHostArch():
   # Figure out host arch using build/detect_host_arch.py and
   # set target_arch to host arch
   detected_host_arch = detect_host_arch.HostArch()
   if detected_host_arch == 'x64':
     return 'amd64'
   elif detected_host_arch == 'ia32':
     return 'i386'
   elif detected_host_arch == 'arm':
     return 'arm'
+  elif detected_host_arch == 'arm64':
+    return 'arm64'
   elif detected_host_arch == 'mips':
     return 'mips'
 
   raise Error('Unrecognized host arch: %s' % detected_host_arch)
 
 
 def DetectTargetArch():
   """Attempt for determine target architecture.
 
   This works by looking for target_arch in GYP_DEFINES.
@@ skipping 19 matching lines @@
 
 
 def InstallDefaultSysroots():
   """Install the default set of sysroot images.
 
   This includes at least the sysroot for host architecture, and the 32-bit
   sysroot for building the v8 snapshot image.  It can also include the cross
   compile sysroot for ARM/MIPS if cross compiling environment can be detected.
   """
   host_arch = DetectHostArch()
-  InstallSysroot(host_arch)
+  InstallDefaultSysrootForArch(host_arch)
 
   if host_arch == 'amd64':
-    InstallSysroot('i386')
+    InstallDefaultSysrootForArch('i386')
+
+  # Desktop Chromium OS builds require the precise sysroot.
+  # TODO(thomasanderson): only download this when the GN arg target_os
+  # == 'chromeos', when the functionality to perform the check becomes
+  # available.
+  InstallSysroot('Precise', 'amd64')

[Dirk Pranke, 2016/08/25 03:27:22]

Another reason we're installing this by default is so that developers can
compile and run on our supported platforms without having to worry about
flipping things back and forth and whether the sysroots have been downloaded or
not (i.e., add that to the docstring above).

[Tom (Use chromium acct), 2016/08/25 18:28:51]

Done.

 
   # Finally, if we can detect a non-standard target_arch such as ARM or
   # MIPS, then install the sysroot too.
   # Don't attampt to install arm64 since this is currently and android-only
   # architecture.
   target_arch = DetectTargetArch()
   if target_arch and target_arch not in (host_arch, 'i386'):
-    InstallSysroot(target_arch)
+    InstallDefaultSysrootForArch(target_arch)
 
 
 def main(args):
   parser = optparse.OptionParser('usage: %prog [OPTIONS]', description=__doc__)
   parser.add_option('--running-as-hook', action='store_true',
                     default=False, help='Used when running from gclient hooks.'
                                         ' Installs default sysroot images.')
   parser.add_option('--arch', type='choice', choices=valid_archs,
                     help='Sysroot architecture: %s' % ', '.join(valid_archs))
   options, _ = parser.parse_args(args)
   if options.running_as_hook and not sys.platform.startswith('linux'):
     return 0
 
   if options.running_as_hook:
     InstallDefaultSysroots()
   else:
     if not options.arch:
       print 'You much specify either --arch or --running-as-hook'
       return 1
-    InstallSysroot(options.arch)
+    InstallDefaultSysrootForArch(options.arch)
 
   return 0
 
+def InstallDefaultSysrootForArch(target_arch):
+  if target_arch == 'amd64':
+    InstallSysroot('Wheezy', 'amd64')
+  elif target_arch == 'arm':
+    InstallSysroot('Wheezy', 'arm')
+  elif target_arch == 'arm64':
+    InstallSysroot('Jessie', 'arm64')
+  elif target_arch == 'i386':
+    InstallSysroot('Wheezy', 'i386')
+  elif target_arch == 'mips':
+    InstallSysroot('Wheezy', 'mips')
+  else:
+    raise Error('Unknown architecture: %s' % target_arch)
 
-def InstallSysroot(target_arch):
+def InstallSysroot(target_platform, target_arch):
   # The sysroot directory should match the one specified in build/common.gypi.
   # TODO(thestig) Consider putting this else where to avoid having to recreate
   # it on every build.
   linux_dir = os.path.dirname(SCRIPT_DIR)
-  debian_release = 'Wheezy'
-  if target_arch == 'amd64':
-    sysroot = os.path.join(linux_dir, SYSROOT_DIR_AMD64)
-    tarball_filename = TARBALL_AMD64
-    tarball_sha1sum = TARBALL_AMD64_SHA1SUM
-    revision = REVISION_AMD64
-  elif target_arch == 'arm':
-    sysroot = os.path.join(linux_dir, SYSROOT_DIR_ARM)
-    tarball_filename = TARBALL_ARM
-    tarball_sha1sum = TARBALL_ARM_SHA1SUM
-    revision = REVISION_ARM
-  elif target_arch == 'arm64':
-    debian_release = 'Jessie'
-    sysroot = os.path.join(linux_dir, SYSROOT_DIR_ARM64)
-    tarball_filename = TARBALL_ARM64
-    tarball_sha1sum = TARBALL_ARM64_SHA1SUM
-    revision = REVISION_ARM64
-  elif target_arch == 'i386':
-    sysroot = os.path.join(linux_dir, SYSROOT_DIR_I386)
-    tarball_filename = TARBALL_I386
-    tarball_sha1sum = TARBALL_I386_SHA1SUM
-    revision = REVISION_I386
-  elif target_arch == 'mips':
-    sysroot = os.path.join(linux_dir, SYSROOT_DIR_MIPS)
-    tarball_filename = TARBALL_MIPS
-    tarball_sha1sum = TARBALL_MIPS_SHA1SUM
-    revision = REVISION_MIPS
-  else:
-    raise Error('Unknown architecture: %s' % target_arch)
+
+  if (target_platform, target_arch) not in sysroots:
+    raise Error('No sysroot for: %s %s' % (target_platform, target_arch))
+  sysroot_dict = sysroots[(target_platform, target_arch)]
+  revision = sysroot_dict['Revision']
+  tarball_filename = sysroot_dict['Tarball']
+  tarball_sha1sum = sysroot_dict['Sha1Sum']
+  sysroot = os.path.join(linux_dir, sysroot_dict['SysrootDir'])
 
   url = '%s/%s/%s/%s' % (URL_PREFIX, URL_PATH, revision, tarball_filename)
 
   stamp = os.path.join(sysroot, '.stamp')
   if os.path.exists(stamp):
     with open(stamp) as s:
       if s.read() == url:
         print 'Debian %s %s root image already up to date: %s' % \
-            (debian_release, target_arch, sysroot)
+            (target_platform, target_arch, sysroot)
         return
 
   print 'Installing Debian %s %s root image: %s' % \
-      (debian_release, target_arch, sysroot)
+      (target_platform, target_arch, sysroot)
   if os.path.isdir(sysroot):
     shutil.rmtree(sysroot)
   os.mkdir(sysroot)
   tarball = os.path.join(sysroot, tarball_filename)
   print 'Downloading %s' % url
   sys.stdout.flush()
   sys.stderr.flush()
   subprocess.check_call(
       ['curl', '--fail', '--retry', '3', '-L', url, '-o', tarball])
   sha1sum = GetSha1(tarball)
   if sha1sum != tarball_sha1sum:
     raise Error('Tarball sha1sum is wrong.'
                 'Expected %s, actual: %s' % (tarball_sha1sum, sha1sum))
   subprocess.check_call(['tar', 'xf', tarball, '-C', sysroot])
   os.remove(tarball)
 
   with open(stamp, 'w') as s:
     s.write(url)
 
 
 if __name__ == '__main__':
   try:
     sys.exit(main(sys.argv[1:]))
   except Error as e:
     sys.stderr.write(str(e) + '\n')
     sys.exit(1)