Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2272273002:
Desktop Chrome OS: Build with precise sysroot (Reland) (Closed)
|
Created:
4 years, 3 months ago by Tom (Use chromium acct) Modified:
4 years, 3 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDesktop Chrome OS: Build with precise sysroot
Build and link against the Ubuntu Precise amd64 sysroot on Desktop
Chrome OS instead of always using the system libraries.
BUG=638394
Committed: https://crrev.com/c575bbcd130b38994e36b0a97bfe5ceea954a643
Committed: https://crrev.com/ec70bbffc5d4ba75ed0f808a0b285236fa54a987
Cr-Original-Commit-Position: refs/heads/master@{#414564}
Cr-Commit-Position: refs/heads/master@{#414862}
Patch Set 1 : Desktop Chrome OS: Build with precise sysroot #
Total comments: 7
Patch Set 2 : Add comments and s/sysroot/SYSROOT #Patch Set 3 : Update license check scripts #
Messages
Total messages: 42 (21 generated)
Patchset #1 (id:1) has been deleted
thomasanderson@google.com changed reviewers: + dpranke@chromium.org
https://codereview.chromium.org/2272273002/diff/20001/build/linux/sysroot_scr... File build/linux/sysroot_scripts/install-sysroot.py (right): https://codereview.chromium.org/2272273002/diff/20001/build/linux/sysroot_scr... build/linux/sysroot_scripts/install-sysroot.py:39: sysroots = { Not sure if this is the most pythonic way to do this
lgtm https://codereview.chromium.org/2272273002/diff/20001/build/config/sysroot.gni File build/config/sysroot.gni (right): https://codereview.chromium.org/2272273002/diff/20001/build/config/sysroot.gn... build/config/sysroot.gni:51: sysroot = "//build/linux/ubuntu_precise_amd64-sysroot" add a comment here about why we're using a precise image for this and not some weird custom sysroot or the default wheezy sysroots (answer is that regular cros builds use custom sys roots but the "desktop chromeos" case needs to run on the builders (which are precise) and a cros build depends on things that aren't in the normal wheezy sysroots). https://codereview.chromium.org/2272273002/diff/20001/build/linux/sysroot_scr... File build/linux/sysroot_scripts/install-sysroot.py (right): https://codereview.chromium.org/2272273002/diff/20001/build/linux/sysroot_scr... build/linux/sysroot_scripts/install-sysroot.py:39: sysroots = { On 2016/08/25 03:09:56, Tom Anderson wrote: > Not sure if this is the most pythonic way to do this Nit: It's a constant, so, SYSROOTS. Otherwise, yes, that's fine. https://codereview.chromium.org/2272273002/diff/20001/build/linux/sysroot_scr... build/linux/sysroot_scripts/install-sysroot.py:157: InstallSysroot('Precise', 'amd64') Another reason we're installing this by default is so that developers can compile and run on our supported platforms without having to worry about flipping things back and forth and whether the sysroots have been downloaded or not (i.e., add that to the docstring above).
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2272273002/diff/20001/build/config/sysroot.gni File build/config/sysroot.gni (right): https://codereview.chromium.org/2272273002/diff/20001/build/config/sysroot.gn... build/config/sysroot.gni:51: sysroot = "//build/linux/ubuntu_precise_amd64-sysroot" On 2016/08/25 03:27:22, Dirk Pranke wrote: > add a comment here about why we're using a precise image for this and not some > weird custom sysroot or the default wheezy sysroots (answer is that regular cros > builds use custom sys roots but the "desktop chromeos" case needs to run on the > builders (which are precise) and a cros build depends on things that aren't in > the normal wheezy sysroots). Done. https://codereview.chromium.org/2272273002/diff/20001/build/linux/sysroot_scr... File build/linux/sysroot_scripts/install-sysroot.py (right): https://codereview.chromium.org/2272273002/diff/20001/build/linux/sysroot_scr... build/linux/sysroot_scripts/install-sysroot.py:39: sysroots = { On 2016/08/25 03:27:22, Dirk Pranke wrote: > On 2016/08/25 03:09:56, Tom Anderson wrote: > > Not sure if this is the most pythonic way to do this > > Nit: It's a constant, so, SYSROOTS. Otherwise, yes, that's fine. Done. https://codereview.chromium.org/2272273002/diff/20001/build/linux/sysroot_scr... build/linux/sysroot_scripts/install-sysroot.py:157: InstallSysroot('Precise', 'amd64') On 2016/08/25 03:27:22, Dirk Pranke wrote: > Another reason we're installing this by default is so that developers can > compile and run on our supported platforms without having to worry about > flipping things back and forth and whether the sysroots have been downloaded or > not (i.e., add that to the docstring above). Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by thomasanderson@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2272273002/#ps40001 (title: "Add comments and s/sysroot/SYSROOT")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Desktop Chrome OS: Build with precise sysroot Build and link against the Ubuntu Precise amd64 sysroot on Desktop Chrome OS instead of always using the system libraries. BUG=638394 ========== to ========== Desktop Chrome OS: Build with precise sysroot Build and link against the Ubuntu Precise amd64 sysroot on Desktop Chrome OS instead of always using the system libraries. BUG=638394 Committed: https://crrev.com/c575bbcd130b38994e36b0a97bfe5ceea954a643 Cr-Commit-Position: refs/heads/master@{#414564} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c575bbcd130b38994e36b0a97bfe5ceea954a643 Cr-Commit-Position: refs/heads/master@{#414564}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:40001) has been created in https://codereview.chromium.org/2285563002/ by jianli@chromium.org. The reason for reverting is: Caused webview_licenses failure: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/3....
Message was sent while issue was closed.
Looks like we need to add the new sysroot directory to: https://cs.chromium.org/chromium/src/tools/copyright_scanner/copyright_scanne... https://cs.chromium.org/chromium/src/tools/checklicenses/checklicenses.py?rcl... I think that may be the only two places.
Message was sent while issue was closed.
On 2016/08/26 01:13:54, Dirk Pranke wrote: > Looks like we need to add the new sysroot directory to: > > https://cs.chromium.org/chromium/src/tools/copyright_scanner/copyright_scanne... > https://cs.chromium.org/chromium/src/tools/checklicenses/checklicenses.py?rcl... > > I think that may be the only two places. This is breaking the Linux Tests bot: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests Would you land the fix asap or revert the CL?
Message was sent while issue was closed.
Description was changed from ========== Desktop Chrome OS: Build with precise sysroot Build and link against the Ubuntu Precise amd64 sysroot on Desktop Chrome OS instead of always using the system libraries. BUG=638394 Committed: https://crrev.com/c575bbcd130b38994e36b0a97bfe5ceea954a643 Cr-Commit-Position: refs/heads/master@{#414564} ========== to ========== Desktop Chrome OS: Build with precise sysroot Build and link against the Ubuntu Precise amd64 sysroot on Desktop Chrome OS instead of always using the system libraries. BUG=638394 Committed: https://crrev.com/c575bbcd130b38994e36b0a97bfe5ceea954a643 Cr-Commit-Position: refs/heads/master@{#414564} ==========
On 2016/08/26 02:31:58, haraken wrote: > On 2016/08/26 01:13:54, Dirk Pranke wrote: > > Looks like we need to add the new sysroot directory to: > > > > > https://cs.chromium.org/chromium/src/tools/copyright_scanner/copyright_scanne... > > > https://cs.chromium.org/chromium/src/tools/checklicenses/checklicenses.py?rcl... > > > > I think that may be the only two places. > > This is breaking the Linux Tests bot: > https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests > > Would you land the fix asap or revert the CL? The CL was reverted in https://codereview.chromium.org/2285563002/ . I don't know why the bot is still failing (will look).
On 2016/08/26 03:44:37, Dirk Pranke wrote: > On 2016/08/26 02:31:58, haraken wrote: > > On 2016/08/26 01:13:54, Dirk Pranke wrote: > > > Looks like we need to add the new sysroot directory to: > > > > > > > > > https://cs.chromium.org/chromium/src/tools/copyright_scanner/copyright_scanne... > > > > > > https://cs.chromium.org/chromium/src/tools/checklicenses/checklicenses.py?rcl... > > > > > > I think that may be the only two places. > > > > This is breaking the Linux Tests bot: > > https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests > > > > Would you land the fix asap or revert the CL? > > The CL was reverted in https://codereview.chromium.org/2285563002/ . > > I don't know why the bot is still failing (will look). I'm guessing that maybe it has something to do w/ the .gitignore suppression. I'll try removing that in https://codereview.chromium.org/2279143002/ .
Updated .gitignore and license check scripts dpranke@ is this safe to land at this point?
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/08/26 17:11:31, Tom Anderson wrote: > Updated .gitignore and license check scripts > > dpranke@ is this safe to land at this point? Probably, but let's wait until either we see the branch announcement or Monday (whichever's earlier).
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Landing due to M54 branch
The CQ bit was checked by thomasanderson@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2272273002/#ps60001 (title: "Update license check scripts")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
thomasanderson@google.com changed reviewers: + thestig@chromium.org
+thestig for checklicenses.py
lgtm
The CQ bit was checked by thomasanderson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Desktop Chrome OS: Build with precise sysroot Build and link against the Ubuntu Precise amd64 sysroot on Desktop Chrome OS instead of always using the system libraries. BUG=638394 Committed: https://crrev.com/c575bbcd130b38994e36b0a97bfe5ceea954a643 Cr-Commit-Position: refs/heads/master@{#414564} ========== to ========== Desktop Chrome OS: Build with precise sysroot Build and link against the Ubuntu Precise amd64 sysroot on Desktop Chrome OS instead of always using the system libraries. BUG=638394 Committed: https://crrev.com/c575bbcd130b38994e36b0a97bfe5ceea954a643 Cr-Commit-Position: refs/heads/master@{#414564} ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Desktop Chrome OS: Build with precise sysroot Build and link against the Ubuntu Precise amd64 sysroot on Desktop Chrome OS instead of always using the system libraries. BUG=638394 Committed: https://crrev.com/c575bbcd130b38994e36b0a97bfe5ceea954a643 Cr-Commit-Position: refs/heads/master@{#414564} ========== to ========== Desktop Chrome OS: Build with precise sysroot Build and link against the Ubuntu Precise amd64 sysroot on Desktop Chrome OS instead of always using the system libraries. BUG=638394 Committed: https://crrev.com/c575bbcd130b38994e36b0a97bfe5ceea954a643 Committed: https://crrev.com/ec70bbffc5d4ba75ed0f808a0b285236fa54a987 Cr-Original-Commit-Position: refs/heads/master@{#414564} Cr-Commit-Position: refs/heads/master@{#414862} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/ec70bbffc5d4ba75ed0f808a0b285236fa54a987 Cr-Commit-Position: refs/heads/master@{#414862} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
