Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 2272253003: Remove calls to deprecated MessageLoop methods from mojo/. (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 3 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to deprecated MessageLoop methods from mojo/. This CL removes calls to these methods from mojo/ files: - MessageLoop::PostTask - MessageLoop::PostDelayedTask - MessageLoop::ReleaseSoon - MessageLoop::DeleteSoon - MessageLoop::Run - MessageLoop::RunUntilIdle BUG=616447 Committed: https://crrev.com/e1f67c7ebef8f522b508172849275e0ff3b77264 Cr-Commit-Position: refs/heads/master@{#415407}

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove unused arguments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M mojo/android/system/base_run_loop.cc View 1 3 chunks +11 lines, -9 lines 0 comments Download
M mojo/android/system/src/org/chromium/mojo/system/impl/BaseRunLoop.java View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
fdoray
PTAL
4 years, 3 months ago (2016-08-26 12:57:58 UTC) #4
jam
https://codereview.chromium.org/2272253003/diff/1/mojo/android/system/base_run_loop.cc File mojo/android/system/base_run_loop.cc (right): https://codereview.chromium.org/2272253003/diff/1/mojo/android/system/base_run_loop.cc#newcode35 mojo/android/system/base_run_loop.cc:35: ->BelongsToCurrentThread()); if try runs passed (which I can't tell, ...
4 years, 3 months ago (2016-08-30 16:33:04 UTC) #5
fdoray
PTAnL
4 years, 3 months ago (2016-08-30 19:10:52 UTC) #10
jam
lgtm
4 years, 3 months ago (2016-08-30 20:16:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272253003/20001
4 years, 3 months ago (2016-08-30 20:22:42 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 20:28:06 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 20:29:52 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e1f67c7ebef8f522b508172849275e0ff3b77264
Cr-Commit-Position: refs/heads/master@{#415407}

Powered by Google App Engine
This is Rietveld 408576698