Add neon and crc32 sources for aarch64

Add neon and crc32 sources for aarch64

This fixes the build for aarch64 arch

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2272243003

Committed: https://skia.googlesource.com/skia/+/b8b3f71c5589aaed8ae76727f3d62642a192b359

[Ankur Mittal, 2016-08-25 01:08:33]

Description was changed from

==========
Add neon and crc32 sources for aarch64

This fixes the build for aarch64 arch

BUG=skia:
==========

to

==========
Add neon and crc32 sources for aarch64

This fixes the build for aarch64 arch

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2272243003
==========

[Ankur Mittal, 2016-08-25 01:08:42]

The CQ bit was checked by anmittal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 01:08:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[anmittal, 2016-08-25 01:09:12]

The CQ bit was unchecked by anmittal@google.com

[anmittal, 2016-08-25 01:13:22]

anmittal@google.com changed reviewers:
+ anmittal@google.com, mtklein@chromium.org

[mtklein, 2016-08-25 01:26:43]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-08-25 01:26:44]

https://codereview.chromium.org/2272243003/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2272243003/diff/1/BUILD.gn#newcode170
BUILD.gn:170: opts("neon_sources") {
Hmm.  It's gonna have to be a little more complicated than this.

opts("armv7") {
  enabled = target_cpu == "arm"
  sources = opts_gypi.armv7_sources
  cflags = []
}

opts("neon") {
  enabled = target_cpu == "arm"
  sources = opts_gypi.neon_sources
  cflags = [ "-mfpu=neon" ]
}

opts("arm64") {
  enabled = target_cpu == "arm64"
  sources = opts_gypi.arm64_sources
  cflags = []
}

opts("crc32") {
  enabled = target_cpu == "arm64"
  sources = opts_gypi.crc32_sources
  cflags = [ "-march=armv8-a+crc" ]
}

and the enabled bit for :none will need to change to
 enabled = !is_x86 && target_cpu != "arm" && target_cpu != "arm64"

[mtklein, 2016-08-25 01:32:38]

On 2016/08/25 01:26:44, mtklein wrote:
> https://codereview.chromium.org/2272243003/diff/1/BUILD.gn
> File BUILD.gn (right):
> 
> https://codereview.chromium.org/2272243003/diff/1/BUILD.gn#newcode170
> BUILD.gn:170: opts("neon_sources") {
> Hmm.  It's gonna have to be a little more complicated than this.
> 
> opts("armv7") {
>   enabled = target_cpu == "arm"
>   sources = opts_gypi.armv7_sources
>   cflags = []
> }
> 
> opts("neon") {
>   enabled = target_cpu == "arm"
>   sources = opts_gypi.neon_sources
>   cflags = [ "-mfpu=neon" ]
> }
> 
> opts("arm64") {
>   enabled = target_cpu == "arm64"
>   sources = opts_gypi.arm64_sources
>   cflags = []
> }
> 
> opts("crc32") {
>   enabled = target_cpu == "arm64"
>   sources = opts_gypi.crc32_sources
>   cflags = [ "-march=armv8-a+crc" ]
> }
> 
> and the enabled bit for :none will need to change to
>  enabled = !is_x86 && target_cpu != "arm" && target_cpu != "arm64"

Err, I think I must have meant current_cpu for all those target_cpus.

[Ankur Mittal, 2016-08-25 03:02:49]

The CQ bit was checked by anmittal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 03:03:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[anmittal, 2016-08-25 03:03:37]

The CQ bit was unchecked by anmittal@google.com

[anmittal, 2016-08-25 03:03:58]

thanks :) fixed BUILD.gn

https://codereview.chromium.org/2272243003/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2272243003/diff/1/BUILD.gn#newcode170
BUILD.gn:170: opts("neon_sources") {
On 2016/08/25 01:26:44, mtklein wrote:
> Hmm.  It's gonna have to be a little more complicated than this.
> 
> opts("armv7") {
>   enabled = target_cpu == "arm"
>   sources = opts_gypi.armv7_sources
>   cflags = []
> }
> 
> opts("neon") {
>   enabled = target_cpu == "arm"
>   sources = opts_gypi.neon_sources
>   cflags = [ "-mfpu=neon" ]
> }
> 
> opts("arm64") {
>   enabled = target_cpu == "arm64"
>   sources = opts_gypi.arm64_sources
>   cflags = []
> }
> 
> opts("crc32") {
>   enabled = target_cpu == "arm64"
>   sources = opts_gypi.crc32_sources
>   cflags = [ "-march=armv8-a+crc" ]
> }
> 
> and the enabled bit for :none will need to change to
>  enabled = !is_x86 && target_cpu != "arm" && target_cpu != "arm64"

Done.

[mtklein, 2016-08-25 11:54:18]

The CQ bit was checked by mtklein@google.com

[mtklein, 2016-08-25 11:54:18]

lgtm

[commit-bot: I haz the power, 2016-08-25 11:54:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 11:55:23]

Description was changed from

==========
Add neon and crc32 sources for aarch64

This fixes the build for aarch64 arch

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2272243003
==========

to

==========
Add neon and crc32 sources for aarch64

This fixes the build for aarch64 arch

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2272243003

Committed:
https://skia.googlesource.com/skia/+/b8b3f71c5589aaed8ae76727f3d62642a192b359
==========

[commit-bot: I haz the power, 2016-08-25 11:55:24]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b8b3f71c5589aaed8ae76727f3d62642a192b359