Remove use of deprecated APIs in WebNavigationApiTest

Remove use of deprecated APIs in WebNavigationApiTest

This CL moves the helper class DelayLoadStartAndExecuteJavascript used in
WebNavigationApiTests to use the new navigation APIs. This allows
WebNavigationApiTest.CrossProcess and WebNavigationApiTest.CrossProcessHistory
to pass with PlzNavigate enabled.

BUG=575230
Committed: https://crrev.com/3363cbef951b26a9111f6cc3004a2a42ed20f49a
Cr-Commit-Position: refs/heads/master@{#421229}

[clamy, 2016-08-25 00:54:34]

The CQ bit was checked by clamy@chromium.org to run a CQ dry run

[clamy, 2016-08-25 00:55:08]

Description was changed from

==========
Remove use of deprecated APIs in WebNavigationApiTest

This CL moves the helper class DelayLoadStartAndExecuteJavascript used in
WebNavigationApiTests to use the new navigation APIs. This allows
WebNavigationApiTest.CrossProcess and WebNavigationApiTest.CrossProcessHistory
to pass with PlzNavigate enabled.

BUG=575230
==========

to

==========
Remove use of deprecated APIs in WebNavigationApiTest

This CL moves the helper class DelayLoadStartAndExecuteJavascript used in
WebNavigationApiTests to use the new navigation APIs. This allows
WebNavigationApiTest.CrossProcess and WebNavigationApiTest.CrossProcessHistory
to pass with PlzNavigate enabled.

BUG=575230
==========

[clamy, 2016-08-25 00:55:08]

clamy@chromium.org changed reviewers:
+ nasko@chromium.org

[clamy, 2016-08-25 00:55:18]

@nasko: PTAL

[commit-bot: I haz the power, 2016-08-25 00:55:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nasko, 2016-08-25 01:05:09]

https://codereview.chromium.org/2272243002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
(right):

https://codereview.chromium.org/2272243002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc:192:
rfh_(NULL) {
nit: nullptr

https://codereview.chromium.org/2272243002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc:228: if
(!navigation_handle->HasCommitted())
Should this also check if the commit was an error page?

[commit-bot: I haz the power, 2016-08-25 02:13:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 02:13:29]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[clamy, 2016-08-25 18:08:57]

The CQ bit was checked by clamy@chromium.org to run a CQ dry run

[clamy, 2016-08-25 18:09:26]

Thanks!

https://codereview.chromium.org/2272243002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
(right):

https://codereview.chromium.org/2272243002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc:192:
rfh_(NULL) {
On 2016/08/25 01:05:09, nasko (out until 08-30) wrote:
> nit: nullptr

Done.

https://codereview.chromium.org/2272243002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc:228: if
(!navigation_handle->HasCommitted())
On 2016/08/25 01:05:09, nasko (out until 08-30) wrote:
> Should this also check if the commit was an error page?

Done.

[commit-bot: I haz the power, 2016-08-25 18:09:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 19:06:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 19:06:39]

Dry run: This issue passed the CQ dry run.

[clamy, 2016-09-27 14:59:27]

@nasko: ping :).

[nasko, 2016-09-27 15:20:44]

Oops, this has fallen through the cracks, sorry : (.
LGTM

[nasko, 2016-09-27 15:20:53]

The CQ bit was checked by nasko@chromium.org

[commit-bot: I haz the power, 2016-09-27 15:21:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 16:11:14]

Description was changed from

==========
Remove use of deprecated APIs in WebNavigationApiTest

This CL moves the helper class DelayLoadStartAndExecuteJavascript used in
WebNavigationApiTests to use the new navigation APIs. This allows
WebNavigationApiTest.CrossProcess and WebNavigationApiTest.CrossProcessHistory
to pass with PlzNavigate enabled.

BUG=575230
==========

to

==========
Remove use of deprecated APIs in WebNavigationApiTest

This CL moves the helper class DelayLoadStartAndExecuteJavascript used in
WebNavigationApiTests to use the new navigation APIs. This allows
WebNavigationApiTest.CrossProcess and WebNavigationApiTest.CrossProcessHistory
to pass with PlzNavigate enabled.

BUG=575230
==========

[commit-bot: I haz the power, 2016-09-27 16:11:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-27 16:12:47]

Description was changed from

==========
Remove use of deprecated APIs in WebNavigationApiTest

This CL moves the helper class DelayLoadStartAndExecuteJavascript used in
WebNavigationApiTests to use the new navigation APIs. This allows
WebNavigationApiTest.CrossProcess and WebNavigationApiTest.CrossProcessHistory
to pass with PlzNavigate enabled.

BUG=575230
==========

to

==========
Remove use of deprecated APIs in WebNavigationApiTest

This CL moves the helper class DelayLoadStartAndExecuteJavascript used in
WebNavigationApiTests to use the new navigation APIs. This allows
WebNavigationApiTest.CrossProcess and WebNavigationApiTest.CrossProcessHistory
to pass with PlzNavigate enabled.

BUG=575230

Committed: https://crrev.com/3363cbef951b26a9111f6cc3004a2a42ed20f49a
Cr-Commit-Position: refs/heads/master@{#421229}
==========

[commit-bot: I haz the power, 2016-09-27 16:12:48]

Patchset 2 (id:??) landed as
https://crrev.com/3363cbef951b26a9111f6cc3004a2a42ed20f49a
Cr-Commit-Position: refs/heads/master@{#421229}