Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2272233002: VTVDA: Fix computation of |reorder_window|. (Closed)

Created:
4 years, 3 months ago by sandersd (OOO until July 31)
Modified:
4 years, 3 months ago
Reviewers:
*DaleCurtis, Pawel Osciak
CC:
chromium-reviews, feature-media-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

VTVDA: Fix computation of |reorder_window|. Prior to this change, VTVDA would disable reordering when there was no VUI max_num_reorder_frames syntax element. This is incorrect; excluding an explicit list of profiles, it should be MaxDpbFrames. The incorrect behavior is masked during normal playback, because decoding is typically faster than rendering. This causes the reorder queue to fill up even though reordering is supposed to be turned off, and frames therefore get a chance to be ordered correctly. BUG=634007 Committed: https://crrev.com/8cbe5d69e18a9c387cfc61adf826ae121cf89834 Cr-Commit-Position: refs/heads/master@{#414499}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -43 lines) Patch
M media/gpu/vt_video_decode_accelerator_mac.cc View 6 chunks +47 lines, -35 lines 0 comments Download
M media/video/h264_poc.cc View 1 chunk +7 lines, -8 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
sandersd (OOO until July 31)
posciak@: If everything looks good, please CQ.
4 years, 3 months ago (2016-08-25 00:40:17 UTC) #3
sandersd (OOO until July 31)
-> dalecurtis@ since I'm trying to commit this before the branch.
4 years, 3 months ago (2016-08-25 17:06:00 UTC) #10
DaleCurtis
lgtm, seems like this needs a test though.
4 years, 3 months ago (2016-08-25 17:55:34 UTC) #11
sandersd (OOO until July 31)
On 2016/08/25 17:55:34, DaleCurtis wrote: > lgtm, seems like this needs a test though. As ...
4 years, 3 months ago (2016-08-25 18:57:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272233002/1
4 years, 3 months ago (2016-08-25 18:58:38 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 19:04:43 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 19:06:34 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8cbe5d69e18a9c387cfc61adf826ae121cf89834
Cr-Commit-Position: refs/heads/master@{#414499}

Powered by Google App Engine
This is Rietveld 408576698