Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1424)

Unified Diff: content/browser/devtools/protocol/browser_handler.cc

Issue 2272213003: DevTools: remove devtools_discovery (merged into content). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: build fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/devtools/devtools_agent_host_impl.cc ('k') | content/content_shell.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/protocol/browser_handler.cc
diff --git a/content/browser/devtools/protocol/browser_handler.cc b/content/browser/devtools/protocol/browser_handler.cc
index d1494f06ca86738a56b61c3991609ab74ac51099..1b53abe690596958ab34ed054d626f9eedc1ab94 100644
--- a/content/browser/devtools/protocol/browser_handler.cc
+++ b/content/browser/devtools/protocol/browser_handler.cc
@@ -4,6 +4,9 @@
#include "content/browser/devtools/protocol/browser_handler.h"
+#include "content/browser/devtools/devtools_manager.h"
+#include "content/public/browser/devtools_manager_delegate.h"
+
namespace content {
namespace devtools {
namespace browser {
@@ -38,9 +41,16 @@ Response BrowserHandler::CreateTarget(const std::string& url,
const int* height,
const std::string* context_id,
std::string* out_target_id) {
- // For layering reasons this needs to be handled by
- // DevToolsManagerDelegate::HandleCommand.
- return Response::ServerError("Not supported");
+ DevToolsManagerDelegate* delegate =
+ DevToolsManager::GetInstance()->delegate();
+ if (!delegate)
+ return Response::ServerError("Not supported");
+ scoped_refptr<content::DevToolsAgentHost> agent_host =
+ delegate->CreateNewTarget(GURL(url));
+ if (!agent_host)
+ return Response::ServerError("Not supported");
+ *out_target_id = agent_host->GetId();
+ return Response::OK();
}
Response BrowserHandler::CloseTarget(const std::string& target_id,
« no previous file with comments | « content/browser/devtools/devtools_agent_host_impl.cc ('k') | content/content_shell.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698