Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: chrome/browser/android/devtools_manager_delegate_android.h

Issue 2272213003: DevTools: remove devtools_discovery (merged into content). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: build fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/devtools_manager_delegate_android.h
diff --git a/chrome/browser/devtools/chrome_devtools_manager_delegate.h b/chrome/browser/android/devtools_manager_delegate_android.h
similarity index 65%
copy from chrome/browser/devtools/chrome_devtools_manager_delegate.h
copy to chrome/browser/android/devtools_manager_delegate_android.h
index 61cde163c3c849fb9378649ee9483671b8a56905..ee3f226b324e7bff41cff2f2e2d072f1cd70c8fe 100644
--- a/chrome/browser/devtools/chrome_devtools_manager_delegate.h
+++ b/chrome/browser/android/devtools_manager_delegate_android.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_DEVTOOLS_CHROME_DEVTOOLS_MANAGER_DELEGATE_H_
-#define CHROME_BROWSER_DEVTOOLS_CHROME_DEVTOOLS_MANAGER_DELEGATE_H_
+#ifndef CHROME_BROWSER_ANDROID_DEVTOOLS_MANAGER_DELEGATE_ANDROID_H_
+#define CHROME_BROWSER_ANDROID_DEVTOOLS_MANAGER_DELEGATE_ANDROID_H_
#include <memory>
@@ -13,13 +13,10 @@
class DevToolsNetworkProtocolHandler;
-class ChromeDevToolsManagerDelegate : public content::DevToolsManagerDelegate {
+class DevToolsManagerDelegateAndroid : public content::DevToolsManagerDelegate {
public:
- static char kTypeApp[];
- static char kTypeBackgroundPage[];
-
- ChromeDevToolsManagerDelegate();
- ~ChromeDevToolsManagerDelegate() override;
+ DevToolsManagerDelegateAndroid();
+ ~DevToolsManagerDelegateAndroid() override;
// content::DevToolsManagerDelegate implementation.
void Inspect(content::DevToolsAgentHost* agent_host) override;
@@ -30,11 +27,13 @@ class ChromeDevToolsManagerDelegate : public content::DevToolsManagerDelegate {
base::DictionaryValue* command_dict) override;
std::string GetTargetType(content::RenderFrameHost* host) override;
std::string GetTargetTitle(content::RenderFrameHost* host) override;
+ scoped_refptr<content::DevToolsAgentHost> CreateNewTarget(
+ const GURL& url) override;
private:
std::unique_ptr<DevToolsNetworkProtocolHandler> network_protocol_handler_;
- DISALLOW_COPY_AND_ASSIGN(ChromeDevToolsManagerDelegate);
+ DISALLOW_COPY_AND_ASSIGN(DevToolsManagerDelegateAndroid);
};
-#endif // CHROME_BROWSER_DEVTOOLS_CHROME_DEVTOOLS_MANAGER_DELEGATE_H_
+#endif // CHROME_BROWSER_ANDROID_DEVTOOLS_MANAGER_DELEGATE_ANDROID_H_

Powered by Google App Engine
This is Rietveld 408576698