Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: android_webview/browser/aw_dev_tools_discovery_provider.cc

Issue 2272213003: DevTools: remove devtools_discovery (merged into content). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: build fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/browser/aw_dev_tools_discovery_provider.h ('k') | chrome/browser/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/aw_dev_tools_discovery_provider.cc
diff --git a/android_webview/browser/aw_dev_tools_discovery_provider.cc b/android_webview/browser/aw_dev_tools_discovery_provider.cc
index 6e2fb5bb87f7e29307ebff4e906d2162eeb80cfb..d29be3f856cbd4ec5673e92a3beb475e3819830d 100644
--- a/android_webview/browser/aw_dev_tools_discovery_provider.cc
+++ b/android_webview/browser/aw_dev_tools_discovery_provider.cc
@@ -10,7 +10,6 @@
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "base/values.h"
-#include "components/devtools_discovery/devtools_discovery_manager.h"
#include "content/public/browser/devtools_agent_host.h"
#include "content/public/browser/web_contents.h"
@@ -39,16 +38,22 @@ std::string GetViewDescription(WebContents* web_contents) {
return json;
}
+content::DevToolsAgentHost::List GetDescriptors() {
+ DevToolsAgentHost::List agent_hosts = DevToolsAgentHost::GetOrCreateAll();
+ for (auto& agent_host : agent_hosts) {
+ agent_host->SetDescriptionOverride(
+ GetViewDescription(agent_host->GetWebContents()));
+ }
+ return agent_hosts;
+}
+
} // namespace
namespace android_webview {
// static
void AwDevToolsDiscoveryProvider::Install() {
- devtools_discovery::DevToolsDiscoveryManager* discovery_manager =
- devtools_discovery::DevToolsDiscoveryManager::GetInstance();
- discovery_manager->AddProvider(
- base::WrapUnique(new AwDevToolsDiscoveryProvider()));
+ content::DevToolsAgentHost::AddDiscoveryProvider(base::Bind(&GetDescriptors));
}
AwDevToolsDiscoveryProvider::AwDevToolsDiscoveryProvider() {
@@ -57,14 +62,4 @@ AwDevToolsDiscoveryProvider::AwDevToolsDiscoveryProvider() {
AwDevToolsDiscoveryProvider::~AwDevToolsDiscoveryProvider() {
}
-content::DevToolsAgentHost::List
-AwDevToolsDiscoveryProvider::GetDescriptors() {
- DevToolsAgentHost::List agent_hosts = DevToolsAgentHost::GetOrCreateAll();
- for (auto& agent_host : agent_hosts) {
- agent_host->SetDescriptionOverride(
- GetViewDescription(agent_host->GetWebContents()));
- }
- return agent_hosts;
-}
-
} // namespace android_webview
« no previous file with comments | « android_webview/browser/aw_dev_tools_discovery_provider.h ('k') | chrome/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698