Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Unified Diff: content/public/browser/devtools_agent_host.h

Issue 2272213003: DevTools: remove devtools_discovery (merged into content). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/devtools_agent_host.h
diff --git a/content/public/browser/devtools_agent_host.h b/content/public/browser/devtools_agent_host.h
index e98f5dc9845f7e64082f82837d3821ee33e64dc7..cfc376f9b500caa119b4603ad1710e22d905851a 100644
--- a/content/public/browser/devtools_agent_host.h
+++ b/content/public/browser/devtools_agent_host.h
@@ -28,6 +28,7 @@ namespace content {
class BrowserContext;
class DevToolsExternalAgentProxyDelegate;
+class DevToolsManagerDelegate;
class RenderFrameHost;
class WebContents;
@@ -43,6 +44,10 @@ class CONTENT_EXPORT DevToolsAgentHost
static char kTypeBrowser[];
static char kTypeOther[];
+ // This is temporary while we are merging http handler and discovery
+ // into content/.
+ static DevToolsManagerDelegate* GetDevToolsManagerDelegate();
+
// Latest DevTools protocol version supported.
static std::string GetProtocolVersion();
@@ -92,11 +97,18 @@ class CONTENT_EXPORT DevToolsAgentHost
static bool IsDebuggerAttached(WebContents* web_contents);
- typedef std::vector<scoped_refptr<DevToolsAgentHost> > List;
+ using List = std::vector<scoped_refptr<DevToolsAgentHost>>;
+
+ using DiscoveryCallback = base::Callback<List()>;
- // Returns all possible DevToolsAgentHosts.
+ static void AddDiscoveryProvider(const DiscoveryCallback& callback);
dgozman 2016/08/25 01:08:11 Add a comment to this one.
+
+ // Returns all DevToolsAgentHosts content is aware of.
static List GetOrCreateAll();
+ // Returns all possible DevToolsAgentHosts embedder is aware of.
+ static List DiscoverAllHosts();
+
// Attaches |client| to this agent host to start debugging.
// Returns true iff attach succeeded.
virtual bool AttachClient(DevToolsAgentHostClient* client) = 0;

Powered by Google App Engine
This is Rietveld 408576698