Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2272213002: Roll recipe dependencies (nontrivial). (Closed)

Created:
4 years, 4 months ago by recipe-roller
Modified:
4 years, 4 months ago
Reviewers:
agable, iannucci
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll recipe dependencies (nontrivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM as normal. The recipe roller will *NOT* CQ the change itself, so you must commit the change manually. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/caa4e0ba756e8a3b5592a604d53ddaf9ba92dfbf Make chromium_tests recipe module explicitly set GIT_MODE (agable@chromium.org) R=agable@chromium.org BUG=640251 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Committed: https://crrev.com/e44f99a1139119b38c2857a1db6bc5b4e9d4d53c Cr-Commit-Position: refs/heads/master@{#414248}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M infra/config/recipes.cfg View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/chromium.expected/builder.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/chromium.expected/tester.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
recipe-roller
4 years, 4 months ago (2016-08-24 23:23:09 UTC) #1
agable
lgtm
4 years, 4 months ago (2016-08-24 23:23:28 UTC) #3
iannucci
lgtm, though those extra svn urls look suspicious/silly?
4 years, 4 months ago (2016-08-24 23:26:35 UTC) #6
agable
On 2016/08/24 at 23:26:35, iannucci wrote: > lgtm, though those extra svn urls look suspicious/silly? ...
4 years, 4 months ago (2016-08-24 23:27:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272213002/1
4 years, 4 months ago (2016-08-24 23:27:35 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-25 02:08:45 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-25 02:12:50 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e44f99a1139119b38c2857a1db6bc5b4e9d4d53c
Cr-Commit-Position: refs/heads/master@{#414248}

Powered by Google App Engine
This is Rietveld 408576698