Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2272193002: [DevTools] Extract small-bubble component. (Closed)

Created:
4 years, 3 months ago by dgozman
Modified:
4 years, 3 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Extract small-bubble component. It's used in ConsoleView messages and UISourceCodeFrame messages. BUG=none Committed: https://crrev.com/81a0c3993dd6405ba4af1e4c34ac79473f702f53 Cr-Commit-Position: refs/heads/master@{#414316}

Patch Set 1 #

Messages

Total messages: 16 (7 generated)
dgozman
Could you please take a look?
4 years, 3 months ago (2016-08-24 22:27:38 UTC) #2
lushnikov
lgtm
4 years, 3 months ago (2016-08-24 22:50:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272193002/1
4 years, 3 months ago (2016-08-24 22:55:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/129363)
4 years, 3 months ago (2016-08-25 01:00:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272193002/1
4 years, 3 months ago (2016-08-25 01:09:31 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/129492)
4 years, 3 months ago (2016-08-25 03:38:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272193002/1
4 years, 3 months ago (2016-08-25 04:00:02 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 05:27:54 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 05:30:41 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/81a0c3993dd6405ba4af1e4c34ac79473f702f53
Cr-Commit-Position: refs/heads/master@{#414316}

Powered by Google App Engine
This is Rietveld 408576698