ResizeObserver: Olipan C++ tests

A new C++ test for ResizeObserver GC.

It tests whether ResizeObserver is kept alive by:
- direct javascript reference
- observing a live element.

BUG=612962
Committed: https://crrev.com/01cdf399a2720f0ac49cd3512c0cdfc8b0439f68
Cr-Commit-Position: refs/heads/master@{#415711}

[atotic1, 2016-08-25 00:11:29]

Description was changed from

==========
Olipan C++ tests

BUG=612962
==========

to

==========
A new C++ test for ResizeObserver GC.

It tests whether ResizeObserver is kept alive by:
- direct javascript reference
- observing a live element.

BUG=612962
==========

[atotic1, 2016-08-25 00:11:29]

atotic@google.com changed reviewers:
+ eae@chromium.org, esprehn@chromium.org

[atotic1, 2016-08-25 00:19:31]

Patchset #1 (id:1) has been deleted

[atotic1, 2016-08-25 00:21:38]

C++ tests for ResizeObserver GC lifetime. They test:
- ResizeObserver is kept alive by direct JS reference
- ResizeObserver is kept alive by observing a live Element

What took so long? I was missing a call to
V8GCController::collectAllGarbageForTesting

[eae, 2016-08-25 18:36:12]

LGTM

Very nice!

[esprehn, 2016-08-30 21:25:23]

lgtm w/ nits

https://codereview.chromium.org/2272163003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/observer/ResizeObserverController.h (right):

https://codereview.chromium.org/2272163003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/observer/ResizeObserverController.h:42:
HeapHashSet<WeakMember<ResizeObserver>>& observers() { return m_observers; }
const HeapHashSet<...> observers() const { ... }

https://codereview.chromium.org/2272163003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/tests/ResizeObserverTest.cpp (right):

https://codereview.chromium.org/2272163003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/tests/ResizeObserverTest.cpp:103: class
ResizeObserverMemoryTest : public SimTest {};
You don't need a new SimTest class for each one. Normally you'd have a single
class like ResizeObserverTest and then use multiple TEST_F's

[atotic1, 2016-08-31 17:24:45]

The CQ bit was checked by atotic@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 17:25:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 19:00:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 19:00:21]

Dry run: This issue passed the CQ dry run.

[atotic1, 2016-08-31 19:04:41]

The CQ bit was checked by atotic@google.com

[atotic1, 2016-08-31 19:04:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
esprehn@chromium.org, eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2272163003/#ps40001
(title: "CR fixes")

[atotic1, 2016-08-31 19:05:15]

Fixed all issues. Comitted.

https://codereview.chromium.org/2272163003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/observer/ResizeObserverController.h (right):

https://codereview.chromium.org/2272163003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/observer/ResizeObserverController.h:42:
HeapHashSet<WeakMember<ResizeObserver>>& observers() { return m_observers; }
On 2016/08/30 at 21:25:23, esprehn wrote:
> const HeapHashSet<...> observers() const { ... }

done.

https://codereview.chromium.org/2272163003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/tests/ResizeObserverTest.cpp (right):

https://codereview.chromium.org/2272163003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/tests/ResizeObserverTest.cpp:103: class
ResizeObserverMemoryTest : public SimTest {};
On 2016/08/30 at 21:25:23, esprehn wrote:
> You don't need a new SimTest class for each one. Normally you'd have a single
class like ResizeObserverTest and then use multiple TEST_F's

Done.

[commit-bot: I haz the power, 2016-08-31 19:05:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 19:10:19]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-08-31 19:12:17]

Description was changed from

==========
A new C++ test for ResizeObserver GC.

It tests whether ResizeObserver is kept alive by:
- direct javascript reference
- observing a live element.

BUG=612962
==========

to

==========
A new C++ test for ResizeObserver GC.

It tests whether ResizeObserver is kept alive by:
- direct javascript reference
- observing a live element.

BUG=612962

Committed: https://crrev.com/01cdf399a2720f0ac49cd3512c0cdfc8b0439f68
Cr-Commit-Position: refs/heads/master@{#415711}
==========

[commit-bot: I haz the power, 2016-08-31 19:12:19]

Patchset 2 (id:??) landed as
https://crrev.com/01cdf399a2720f0ac49cd3512c0cdfc8b0439f68
Cr-Commit-Position: refs/heads/master@{#415711}