ui/gfx/native_pixmap_handle.h - Issue 2272153002: Add ClientNativePixmap multi-planar support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/native_pixmap_handle.h

Issue 2272153002: Add ClientNativePixmap multi-planar support. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@client-native-pixmap-dmabug-multiple-planes

Patch Set: s/cstddef/stddef.h Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « media/gpu/video_decode_accelerator_unittest.cc ('k') | ui/gfx/native_pixmap_handle.cc » ('j') | ui/ozone/platform/drm/client_native_pixmap_factory_gbm.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/gfx/native_pixmap_handle.h

diff --git a/ui/gfx/native_pixmap_handle.h b/ui/gfx/native_pixmap_handle.h

index 767951b7cb1f44a6ebbceb30c9ec490d34504de4..ceb5242379fe57a5107d4e2d1e49cd918b2497a7 100644

--- a/ui/gfx/native_pixmap_handle.h

+++ b/ui/gfx/native_pixmap_handle.h

@@ -5,7 +5,7 @@

#ifndef UI_GFX_NATIVE_PIXMAP_HANDLE_H_

#define UI_GFX_NATIVE_PIXMAP_HANDLE_H_

-#include <stdint.h>

+#include <stddef.h>

#include <vector>

#include "ui/gfx/gfx_export.h"

@@ -20,7 +20,7 @@ namespace gfx {

// buffer. More fields can be added if they are plane specific.

struct GFX_EXPORT NativePixmapPlane {

NativePixmapPlane();

- NativePixmapPlane(int stride, int offset, uint64_t modifier);

+ NativePixmapPlane(int stride, int offset, size_t size, uint64_t modifier);

NativePixmapPlane(const NativePixmapPlane& other);

~NativePixmapPlane();

@@ -28,6 +28,9 @@ struct GFX_EXPORT NativePixmapPlane {

// a memory mapping. One per plane per entry.

int stride;

int offset;

+ // Size in bytes of the plane.

+ // This is necessary to map the buffers.

+ size_t size;

// The modifier is retrieved from GBM library and passed to EGL driver.

// Generally it's platform specific, and we don't need to modify it in

// Chromium code. Also one per plane per entry.