Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2272133002: [ios] Updated CreateMockWKWebViewWithStubbedJSEvalFunction comments. (Closed)

Created:
4 years, 4 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 4 months ago
Reviewers:
Jackie Quinn
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Updated CreateMockWKWebViewWithStubbedJSEvalFunction comments. s/stringResultHandler/completionHandler BUG=None Committed: https://crrev.com/f0bbe54f09056f8b577cd47f4d3c6469d2160ced Cr-Commit-Position: refs/heads/master@{#414159}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ios/web/test/wk_web_view_crash_utils.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Eugene But (OOO till 7-30)
4 years, 4 months ago (2016-08-24 19:06:40 UTC) #2
Jackie Quinn
lgtm
4 years, 4 months ago (2016-08-24 19:55:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272133002/1
4 years, 4 months ago (2016-08-24 19:55:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 21:53:54 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 21:57:09 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f0bbe54f09056f8b577cd47f4d3c6469d2160ced
Cr-Commit-Position: refs/heads/master@{#414159}

Powered by Google App Engine
This is Rietveld 408576698