Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2494)

Unified Diff: chrome/browser/plugins/flash_download_interception_unittest.cc

Issue 2272123002: [HBD] Intercept navigation to Flash download page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: EXPECT_EQ to ASSERT_EQ for WillStartRequest() checks Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/plugins/flash_download_interception_unittest.cc
diff --git a/chrome/browser/plugins/flash_download_interception_unittest.cc b/chrome/browser/plugins/flash_download_interception_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..205c75355e70e5662bf453609733e93aa76d91c4
--- /dev/null
+++ b/chrome/browser/plugins/flash_download_interception_unittest.cc
@@ -0,0 +1,94 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/plugins/flash_download_interception.h"
+
+#include "base/test/scoped_feature_list.h"
+#include "chrome/common/chrome_features.h"
+#include "chrome/test/base/chrome_render_view_host_test_harness.h"
+#include "content/public/browser/navigation_handle.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "url/gurl.h"
+
+using content::NavigationHandle;
+using content::NavigationThrottle;
+
+class FlashDownloadInterceptionTest : public ChromeRenderViewHostTestHarness {
+ public:
+ FlashDownloadInterceptionTest() {}
+
+ void SetUp() override {
+ ChromeRenderViewHostTestHarness::SetUp();
+ flash_navigation_handle_ =
+ NavigationHandle::CreateNavigationHandleForTesting(
+ GURL("https://get.adobe.com/flashplayer"), main_rfh());
+ flash_slash_navigation_handle_ =
+ NavigationHandle::CreateNavigationHandleForTesting(
+ GURL("https://get.adobe.com/flashplayer/"), main_rfh());
+ example_navigation_handle_ =
+ NavigationHandle::CreateNavigationHandleForTesting(
+ GURL("https://www.example.com"), main_rfh());
+
+ // Changes the status of the navigation handles. This is needed because
+ // the NavigationHandle's status needs to be different from INITIAL so that
+ // the HasUserGesture method can be used.
+ flash_navigation_handle_->CallWillProcessResponseForTesting(main_rfh());
+ flash_slash_navigation_handle_->CallWillProcessResponseForTesting(
+ main_rfh());
+ example_navigation_handle_->CallWillProcessResponseForTesting(main_rfh());
+ }
+
+ void TearDown() override {
+ flash_navigation_handle_.reset();
+ flash_slash_navigation_handle_.reset();
+ example_navigation_handle_.reset();
+ ChromeRenderViewHostTestHarness::TearDown();
+ }
+
+ protected:
+ std::unique_ptr<NavigationHandle> flash_navigation_handle_;
+ std::unique_ptr<NavigationHandle> flash_slash_navigation_handle_;
+ std::unique_ptr<NavigationHandle> example_navigation_handle_;
+};
+
+TEST_F(FlashDownloadInterceptionTest, PreferHtmlOverPluginsOff) {
+ base::test::ScopedFeatureList feature_list;
+ feature_list.InitAndDisableFeature(features::kPreferHtmlOverPlugins);
+
+ flash_navigation_handle_->SetHasUserGestureForTesting(true);
+ std::unique_ptr<NavigationThrottle> throttle =
+ FlashDownloadInterception::MaybeCreateThrottleFor(
+ flash_navigation_handle_.get());
+ EXPECT_EQ(nullptr, throttle);
+}
+
+TEST_F(FlashDownloadInterceptionTest, PreferHtmlOverPluginsOn) {
+ std::unique_ptr<NavigationThrottle> throttle;
+ base::test::ScopedFeatureList feature_list;
+ feature_list.InitAndEnableFeature(features::kPreferHtmlOverPlugins);
+
+ flash_navigation_handle_->SetHasUserGestureForTesting(false);
+ throttle = FlashDownloadInterception::MaybeCreateThrottleFor(
+ flash_navigation_handle_.get());
+ EXPECT_EQ(nullptr, throttle);
+
+ flash_navigation_handle_->SetHasUserGestureForTesting(true);
+ throttle = FlashDownloadInterception::MaybeCreateThrottleFor(
+ flash_navigation_handle_.get());
+ EXPECT_NE(nullptr, throttle);
+ ASSERT_EQ(NavigationThrottle::CANCEL_AND_IGNORE,
+ throttle->WillStartRequest());
+
+ flash_slash_navigation_handle_->SetHasUserGestureForTesting(true);
+ throttle = FlashDownloadInterception::MaybeCreateThrottleFor(
+ flash_navigation_handle_.get());
+ EXPECT_NE(nullptr, throttle);
+ ASSERT_EQ(NavigationThrottle::CANCEL_AND_IGNORE,
+ throttle->WillStartRequest());
+
+ example_navigation_handle_->SetHasUserGestureForTesting(true);
+ throttle = FlashDownloadInterception::MaybeCreateThrottleFor(
+ example_navigation_handle_.get());
+ EXPECT_EQ(nullptr, throttle);
+}

Powered by Google App Engine
This is Rietveld 408576698