[HBD] Intercept navigation to Flash download page

chrome/browser/plugins/flash_download_interception.h

Index: chrome/browser/plugins/flash_download_interception.h
diff --git a/chrome/browser/apps/app_url_redirector.h b/chrome/browser/plugins/flash_download_interception.h
similarity index 64%
copy from chrome/browser/apps/app_url_redirector.h
copy to chrome/browser/plugins/flash_download_interception.h
index 8f298db1c1ae7012ebca9b5b5196509b927db420..03b7a6ead2c0716e5173c6afb651d5f83f24ffa7 100644
--- a/chrome/browser/apps/app_url_redirector.h
+++ b/chrome/browser/plugins/flash_download_interception.h
@@ -1,9 +1,9 @@
-// Copyright 2013 The Chromium Authors. All rights reserved.
+// Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_BROWSER_APPS_APP_URL_REDIRECTOR_H_
-#define CHROME_BROWSER_APPS_APP_URL_REDIRECTOR_H_
+#ifndef CHROME_BROWSER_PLUGINS_FLASH_DOWNLOAD_INTERCEPTION_H_
+#define CHROME_BROWSER_PLUGINS_FLASH_DOWNLOAD_INTERCEPTION_H_
 
 #include <memory>
 
@@ -13,19 +13,18 @@
 namespace content {
 class NavigationHandle;
 class NavigationThrottle;
-class WebContents;
 }
 
 // This class creates navigation throttles that redirect URLs to apps that have
 // a matching URL handler in the 'url_handlers' manifest key. Note that this is
 // a UI thread class.
-class AppUrlRedirector {
+class FlashDownloadInterception {

[tommycli, 2016/08/24 19:11:30]

class comment should be updated. something similar to:

// Redirects Flash Download URL navigations, since Chrome already ships with
Flash.

Use your imagination :)

Also do you think it should be named similarly to the AppUrlRedirector? i.e.
FlashDownloadUrlRedirector?

I'm not sure, but think about it.

[trizzofo, 2016/08/24 22:45:13]

Changed the comment. ptal.

I decided to name the class FlashDownloadInterception because I believe that
what we're doing here isn't exactly a redirection. Is it? Correct me if I'm
wrong.

Maybe the name can be interpreted by some as an actual Flash download intercept,
and that's not the case. Maybe I should rename it to
FlashDownloadUrlInterception? Let me know what you think.

  public:
   static std::unique_ptr<content::NavigationThrottle> MaybeCreateThrottleFor(
       content::NavigationHandle* handle);
 
  private:
-  DISALLOW_COPY_AND_ASSIGN(AppUrlRedirector);
+  DISALLOW_COPY_AND_ASSIGN(FlashDownloadInterception);
 };
 
-#endif  // CHROME_BROWSER_APPS_APP_URL_REDIRECTOR_H_
+#endif  // CHROME_BROWSER_PLUGINS_FLASH_DOWNLOAD_INTERCEPTION_H_