[HBD] Intercept navigation to Flash download page

chrome/browser/plugins/flash_download_interception.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PLUGINS_FLASH_DOWNLOAD_INTERCEPTION_H_
+#define CHROME_BROWSER_PLUGINS_FLASH_DOWNLOAD_INTERCEPTION_H_
+
+#include <memory>
+
+#include "base/macros.h"
+#include "content/public/browser/navigation_throttle.h"
+
+namespace content {
+class NavigationHandle;
+class NavigationThrottle;

[Lei Zhang, 2016/08/25 00:55:07]

Either this is not needed, or the navigation_throttle.h include is not.

[trizzofo, 2016/08/25 01:50:36]

Done.

+}
+
+// This class creates navigation throttles that intercept navigations to Flash's
+// download page. The user is queried about activating Flash instead, since
+// Chrome already ships with it. Note that this is an UI thread class.
+class FlashDownloadInterception {
+ public:
+  static std::unique_ptr<content::NavigationThrottle> MaybeCreateThrottleFor(

[Lei Zhang, 2016/08/25 00:55:07]

Would unit tests be useful?

[trizzofo, 2016/08/25 01:50:36]

Apparently, AppUrlRedirector (similar class) is tested with browser tests. I
don't know which is better. I'll take a better look and talk with tommycli@
about it.

[trizzofo, 2016/08/25 20:46:52]

Since this CL is blocking some UI work (permission prompt), it would be good to
commit it asap and take care of tests later.

+      content::NavigationHandle* handle);
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(FlashDownloadInterception);
+};
+
+#endif  // CHROME_BROWSER_PLUGINS_FLASH_DOWNLOAD_INTERCEPTION_H_