Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2272103002: SkPDF: set SK_SFNTLY_SUBSETTER uniformly (Closed)

Created:
4 years, 3 months ago by hal.canary
Modified:
4 years, 3 months ago
Reviewers:
dogben
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: set SK_SFNTLY_SUBSETTER uniformly When Skia is built into the Android framework, SK_SFNTLY_SUBSETTER="sample/chromium/font_subsetter.h". This #includes the same value for GOOGLE3. Once Chrome is also using this value, we can do away with the `#ifdef GOOGLE3` line. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2272103002 Committed: https://skia.googlesource.com/skia/+/e59cb1c1f1ab8f0a610889f4de9b3f20e174a94d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pdf/SkPDFFont.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (11 generated)
hal.canary
how do I test this CL?
4 years, 3 months ago (2016-08-24 18:34:03 UTC) #6
dogben
lgtm
4 years, 3 months ago (2016-08-24 20:46:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272103002/1
4 years, 3 months ago (2016-08-24 21:25:16 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-24 21:42:14 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e59cb1c1f1ab8f0a610889f4de9b3f20e174a94d

Powered by Google App Engine
This is Rietveld 408576698